components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc - Issue 2561493002: Pass Physical Web metadata through a struct

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

Issue 2561493002: Pass Physical Web metadata through a struct (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/physical_web/physical_web_data_source_android.cc ('K') | « chrome/browser/android/physical_web/physical_web_data_source_android.cc ('k') | components/omnibox/browser/physical_web_provider.cc » ('j') | components/omnibox/browser/physical_web_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

index 93179bd19c533fa3fd238a4f18df88bd9cd228e0..1efa79f3f7bda38c665b161f19e6717e0f2d4609 100644

--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

@@ -153,7 +153,7 @@ PhysicalWebPageSuggestionsProvider::GetMostRecentPhysicalWebPagesWithFilter(

int max_quantity,

const std::set<std::string>& excluded_ids) {

std::unique_ptr<ListValue> page_values =

- physical_web_data_source_->GetMetadata();

+ physical_web_data_source_->GetMetadataListValue();

std::vector<const DictionaryValue*> page_dictionaries;

for (const std::unique_ptr<Value>& page_value : *page_values) {