Pass Physical Web metadata through a struct

chrome/browser/android/physical_web/physical_web_data_source_android.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/physical_web/physical_web_data_source_android.h"
 
 #include <jni.h>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/memory/ptr_util.h"
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "jni/UrlManager_jni.h"
 
 using base::android::AttachCurrentThread;
 using base::android::ConvertJavaStringToUTF8;
 using base::android::JavaParamRef;
 using base::android::ScopedJavaLocalRef;
 
 PhysicalWebCollection::PhysicalWebCollection()
-    : metadata_list_(base::MakeUnique<base::ListValue>()),
+    : dictionary_value_list_(base::MakeUnique<base::ListValue>()),
+      metadata_list_(base::MakeUnique<physical_web::MetadataList>()),
       accessed_once_(false) {}
 
 PhysicalWebCollection::~PhysicalWebCollection() {}
 
 void PhysicalWebCollection::AppendMetadataItem(
     JNIEnv* env,
     const JavaParamRef<jobject>& obj,
     const JavaParamRef<jstring>& j_request_url,
     jdouble distance_estimate,
-    jint scan_timestamp,
+    jlong scan_timestamp,
     const JavaParamRef<jstring>& j_site_url,
     const JavaParamRef<jstring>& j_icon_url,
     const JavaParamRef<jstring>& j_title,
     const JavaParamRef<jstring>& j_description,
     const JavaParamRef<jstring>& j_group_id) {
-  auto metadata_item = new base::DictionaryValue();
-  metadata_item->SetString(physical_web::kScannedUrlKey,
+  // Create a DictionaryValue.  Notice that we no longer set the timestamp
+  // since it is a long and the DictionaryValue can only store ints.
+  auto dictionary_value = base::MakeUnique<base::DictionaryValue>();
+  dictionary_value->SetString(physical_web::kScannedUrlKey,
                            ConvertJavaStringToUTF8(j_request_url));
-  metadata_item->SetDouble(physical_web::kDistanceEstimateKey,
+  dictionary_value->SetDouble(physical_web::kDistanceEstimateKey,
                            distance_estimate);
-  metadata_item->SetInteger(physical_web::kScanTimestampKey, scan_timestamp);
-  metadata_item->SetString(physical_web::kResolvedUrlKey,
+  dictionary_value->SetString(physical_web::kResolvedUrlKey,
                            ConvertJavaStringToUTF8(j_site_url));
-  metadata_item->SetString(physical_web::kIconUrlKey,
+  dictionary_value->SetString(physical_web::kIconUrlKey,
                            ConvertJavaStringToUTF8(j_icon_url));
-  metadata_item->SetString(physical_web::kTitleKey,
+  dictionary_value->SetString(physical_web::kTitleKey,
                            ConvertJavaStringToUTF8(j_title));
-  metadata_item->SetString(physical_web::kDescriptionKey,
+  dictionary_value->SetString(physical_web::kDescriptionKey,
                            ConvertJavaStringToUTF8(j_description));
-  metadata_item->SetString(physical_web::kGroupIdKey,
+  dictionary_value->SetString(physical_web::kGroupIdKey,
                            ConvertJavaStringToUTF8(j_group_id));
-  metadata_list_->Append(std::move(metadata_item));
+  dictionary_value_list_->Append(std::move(dictionary_value));
+
+  physical_web::Metadata metadata;
+  metadata.scanned_url = ConvertJavaStringToUTF8(j_request_url);
+  metadata.resolved_url = ConvertJavaStringToUTF8(j_site_url);
+  metadata.icon_url = ConvertJavaStringToUTF8(j_icon_url);
+  metadata.title = ConvertJavaStringToUTF8(j_title);
+  metadata.description = ConvertJavaStringToUTF8(j_description);
+  metadata.group_id = ConvertJavaStringToUTF8(j_group_id);
+  metadata.distance_estimate = distance_estimate;
+  metadata.scan_timestamp = scan_timestamp;

[vitaliii, 2016/12/09 09:52:49]

I do not feel that this works as expected.
But even if it does it would be nice to make the conversion more explicit.
There is base::Time::FromJavaTime, which may be useful. 

[cco3, 2016/12/10 00:25:23]

Yea, I didn't think it would either.  Thanks for finding this.

[vitaliii, 2016/12/12 07:04:13]

Acknowledged.

+  metadata_list_->push_back(std::move(metadata_item));
 }
 
-std::unique_ptr<base::ListValue> PhysicalWebCollection::GetMetadataList() {
+std::unique_ptr<physical_web::MetadataList>
+    PhysicalWebCollection::GetMetadataList() {
   DCHECK(!accessed_once_);
   accessed_once_ = true;
   return std::move(metadata_list_);
 }
 
+std::unique_ptr<base::ListValue>
+    PhysicalWebCollection::GetMetadataListValue() {
+  DCHECK(!accessed_once_);
+  accessed_once_ = true;
+  return std::move(dictionary_value_list_);
+}
+
 PhysicalWebDataSourceAndroid::PhysicalWebDataSourceAndroid() {
   Initialize();
 }
 
 PhysicalWebDataSourceAndroid::~PhysicalWebDataSourceAndroid() {}
 
 void PhysicalWebDataSourceAndroid::Initialize() {
   JNIEnv* env = AttachCurrentThread();
 
   // Cache a reference to the singleton instance of UrlManager.
   url_manager_.Reset(Java_UrlManager_getInstance(env));
   DCHECK(url_manager_.obj());
 }
 
 void PhysicalWebDataSourceAndroid::StartDiscovery(
     bool network_request_enabled) {
   // On Android, scanning is started and stopped through the Java layer.
   NOTREACHED();
 }
 
 void PhysicalWebDataSourceAndroid::StopDiscovery() {
   // On Android, scanning is started and stopped through the Java layer.
   NOTREACHED();
 }
 
-std::unique_ptr<base::ListValue> PhysicalWebDataSourceAndroid::GetMetadata() {
+std::unique_ptr<physical_web::MetadataList>
+    PhysicalWebDataSourceAndroid::GetMetadata() {
   JNIEnv* env = AttachCurrentThread();
 
   auto pw_collection = base::MakeUnique<PhysicalWebCollection>();
   Java_UrlManager_getPwCollection(env, url_manager_.obj(),
                                   (long)pw_collection.get());
 
   return pw_collection->GetMetadataList();
 }
 
+std::unique_ptr<base::ListValue>
+    PhysicalWebDataSourceAndroid::GetMetadataListValue() {
+  JNIEnv* env = AttachCurrentThread();
+
+  auto pw_collection = base::MakeUnique<PhysicalWebCollection>();
+  Java_UrlManager_getPwCollection(env, url_manager_.obj(),
+                                  (long)pw_collection.get());
+
+  return pw_collection->GetMetadataListValue();
+}
+
 bool PhysicalWebDataSourceAndroid::HasUnresolvedDiscoveries() {
   NOTIMPLEMENTED();
   return false;
 }
 
 void PhysicalWebDataSourceAndroid::OnFound(
     JNIEnv* env,
     const base::android::JavaParamRef<jobject>& obj,
     const base::android::JavaParamRef<jstring>& j_url) {
   std::string url = ConvertJavaStringToUTF8(env, j_url);
@@ skipping 20 matching lines @@
 // static
 bool PhysicalWebDataSourceAndroid::RegisterPhysicalWebDataSource(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 static jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj) {
   physical_web::PhysicalWebDataSource* data_source =
       g_browser_process->GetPhysicalWebDataSource();
   return reinterpret_cast<intptr_t>(data_source);
 }