Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2828)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 2561463004: Refactor ZoomControlsDelegate out of ContentViewCore (Closed)
Patch Set: Rebase (no actual changes needed) Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwZoomControls.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/java/src/org/chromium/android_webview/AwContents.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java
index 71f6033652e5ffd6426472c5932dcf964ce28739..508cc11f9b91c35d4d75b14aaea57604ccd32de9 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java
@@ -633,6 +633,22 @@ public class AwContents implements SmartClipProvider, PostMessageSender.PostMess
@Override
public void onScrollUpdateGestureConsumed() {
mScrollAccessibilityHelper.postViewScrolledAccessibilityEventCallback();
+ mZoomControls.invokeZoomPicker();
+ }
+
+ @Override
+ public void onScrollStarted(int scrollOffsetY, int scrollExtentY) {
+ mZoomControls.invokeZoomPicker();
+ }
+
+ @Override
+ public void onScaleLimitsChanged(float minPageScaleFactor, float maxPageScaleFactor) {
+ mZoomControls.invokeZoomPicker();
+ }
+
+ @Override
+ public void onScrollOffsetOrExtentChanged(int scrollOffsetY, int scrollExtentY) {
+ mZoomControls.updateZoomControls();
}
}
@@ -793,14 +809,12 @@ public class AwContents implements SmartClipProvider, PostMessageSender.PostMess
Context context, ViewAndroidDelegate viewDelegate,
InternalAccessDelegate internalDispatcher, WebContents webContents,
GestureStateListener gestureStateListener, ContentViewClient contentViewClient,
- ContentViewCore.ZoomControlsDelegate zoomControlsDelegate,
WindowAndroid windowAndroid) {
contentViewCore.initialize(viewDelegate, internalDispatcher, webContents, windowAndroid);
contentViewCore.setActionModeCallback(
new AwActionModeCallback(this, contentViewCore.getActionModeCallbackHelper()));
contentViewCore.addGestureStateListener(gestureStateListener);
contentViewCore.setContentViewClient(contentViewClient);
- contentViewCore.setZoomControlsDelegate(zoomControlsDelegate);
}
boolean isFullScreen() {
@@ -1040,7 +1054,7 @@ public class AwContents implements SmartClipProvider, PostMessageSender.PostMess
mContentViewCore.getRenderCoordinates());
initializeContentViewCore(mContentViewCore, mContext, mViewAndroidDelegate,
mInternalAccessAdapter, webContents, new AwGestureStateListener(),
- mContentViewClient, mZoomControls, mWindowAndroid.getWindowAndroid());
+ mContentViewClient, mWindowAndroid.getWindowAndroid());
nativeSetJavaPeers(mNativeAwContents, this, mWebContentsDelegate, mContentsClientBridge,
mIoThreadClient, mInterceptNavigationDelegate);
mWebContents = mContentViewCore.getWebContents();
@@ -2170,7 +2184,7 @@ public class AwContents implements SmartClipProvider, PostMessageSender.PostMess
*/
public void invokeZoomPicker() {
if (TRACE) Log.i(TAG, "%s invokeZoomPicker", this);
- if (!isDestroyed(WARN)) mContentViewCore.invokeZoomPicker();
+ if (!isDestroyed(WARN)) mZoomControls.invokeZoomPicker();
}
/**
@@ -3162,6 +3176,7 @@ public class AwContents implements SmartClipProvider, PostMessageSender.PostMess
}
mScrollAccessibilityHelper.removePostedCallbacks();
+ mZoomControls.dismissZoomPicker();
}
@Override
« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwZoomControls.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698