Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2561463003: MacViews: Re-enable StyledLabelTest.StyledRangeBold. (Closed)

Created:
4 years ago by tapted
Modified:
4 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Re-enable StyledLabelTest.StyledRangeBold. This was likely fixed after r410525 "Fix PlatformFontMac::DeriveFont". BUG=622983 Committed: https://crrev.com/e30ab1e74491f83690c2e125c4a3e1b26c457583 Cr-Commit-Position: refs/heads/master@{#437196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M ui/views/controls/styled_label_unittest.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tapted
Hi sky, please take a look
4 years ago (2016-12-07 23:41:04 UTC) #6
sky
LGTM
4 years ago (2016-12-08 03:59:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561463003/1
4 years ago (2016-12-08 05:37:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 06:22:40 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-08 06:26:44 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e30ab1e74491f83690c2e125c4a3e1b26c457583
Cr-Commit-Position: refs/heads/master@{#437196}

Powered by Google App Engine
This is Rietveld 408576698