Chromium Code Reviews| Index: content/renderer/render_frame_impl.cc |
| diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc |
| index f68bb2e5666f71404361907fd889992464b5d5cf..80b5afaf61cc2425046917745c9bc503fda69f48 100644 |
| --- a/content/renderer/render_frame_impl.cc |
| +++ b/content/renderer/render_frame_impl.cc |
| @@ -1477,13 +1477,7 @@ bool RenderFrameImpl::OnMessageReceived(const IPC::Message& msg) { |
| if (!frame_) |
| return false; |
| - // TODO(kenrb): document() should not be null, but as a transitional step |
| - // we have RenderFrameProxy 'wrapping' a RenderFrameImpl, passing messages |
| - // to this method. This happens for a top-level remote frame, where a |
| - // document-less RenderFrame is replaced by a RenderFrameProxy but kept |
| - // around and is still able to receive messages. |
| - if (!frame_->document().isNull()) |
| - GetContentClient()->SetActiveURL(frame_->document().url()); |
|
nasko
2016/12/07 00:25:13
We shouldn't be losing the call to SetActiveURL, r
kenrb
2016/12/07 00:33:59
Yes, sloppy error, fixed now.
|
| + DCHECK(!frame_->document().isNull()); |
| for (auto& observer : observers_) { |
| if (observer.OnMessageReceived(msg)) |