Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2561453002:
Remove null Document check from RenderFrameImpl::OnMessageReceived (Closed)
DescriptionRemove null Document check from RenderFrameImpl::OnMessageReceived
This check is obsolete, there should no longer be any case where the
Document is null at this point.
BUG=671786
Committed: https://crrev.com/6241c26f033f7c7e691c76f4c885c96387e81932
Cr-Commit-Position: refs/heads/master@{#437284}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix for real this time #Messages
Total messages: 19 (12 generated)
The CQ bit was checked by kenrb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
kenrb@chromium.org changed reviewers: + nasko@chromium.org
Nasko: PTAL?
https://codereview.chromium.org/2561453002/diff/1/content/renderer/render_fra... File content/renderer/render_frame_impl.cc (left): https://codereview.chromium.org/2561453002/diff/1/content/renderer/render_fra... content/renderer/render_frame_impl.cc:1486: GetContentClient()->SetActiveURL(frame_->document().url()); We shouldn't be losing the call to SetActiveURL, right?
The CQ bit was checked by kenrb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2561453002/diff/1/content/renderer/render_fra... File content/renderer/render_frame_impl.cc (left): https://codereview.chromium.org/2561453002/diff/1/content/renderer/render_fra... content/renderer/render_frame_impl.cc:1486: GetContentClient()->SetActiveURL(frame_->document().url()); On 2016/12/07 00:25:13, nasko (very slow til Dec 13th) wrote: > We shouldn't be losing the call to SetActiveURL, right? Yes, sloppy error, fixed now.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by nasko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481216467554460,
"parent_rev": "c438735fa00768ba50eaa0c5528029918ad6de39", "commit_rev":
"5b973eaff859669b96e23d9b94320beab781517f"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove null Document check from RenderFrameImpl::OnMessageReceived This check is obsolete, there should no longer be any case where the Document is null at this point. BUG=671786 ========== to ========== Remove null Document check from RenderFrameImpl::OnMessageReceived This check is obsolete, there should no longer be any case where the Document is null at this point. BUG=671786 Committed: https://crrev.com/6241c26f033f7c7e691c76f4c885c96387e81932 Cr-Commit-Position: refs/heads/master@{#437284} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6241c26f033f7c7e691c76f4c885c96387e81932 Cr-Commit-Position: refs/heads/master@{#437284} |
