Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3266)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPage.java

Issue 2561433002: Make FirstRunActivity extend AsyncInitializationActivity. (Closed)
Patch Set: Update UX. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPage.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPage.java
index 7221c6ff8ef203b80f62f21e5d3c39647d389302..032b286c3fe990c20a37c808988f13e5b1d7438f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPage.java
@@ -49,6 +49,13 @@ public class FirstRunPage extends Fragment {
}
/**
+ * @return Whether the page should be re-created when notifyDataSetChanged() fires.
+ */
+ public boolean shouldRecreatePageOnDataChange() {
+ return true;
+ }
+
+ /**
* @return Passed arguments if any, or saved instance state if any, or an empty bundle.
*/
protected Bundle getProperties() {
@@ -68,4 +75,9 @@ public class FirstRunPage extends Fragment {
protected void advanceToNextPage() {
getPageDelegate().advanceToNextPage();
}
-}
+
+ /**
+ * Notifies this page that native has been initialized.
+ */
+ protected void onNativeInitialized() {}
+}

Powered by Google App Engine
This is Rietveld 408576698