chrome/android/java/res/values/ids.xml - Issue 2561373002: [Payment Request] Keep selection for edited item when canceling editors

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/values/ids.xml

Issue 2561373002: [Payment Request] Keep selection for edited item when canceling editors (Closed)

Patch Set: now handling the + ADD ITEM case Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2	2

3 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	3 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

4	4

5 Use of this source code is governed by a BSD-style license that can be	5 Use of this source code is governed by a BSD-style license that can be

6 found in the LICENSE file.	6 found in the LICENSE file.

7 -->	7 -->

8	8

9 <resources>	9 <resources>

10 <item name="background_drawable" type="id"/>	10 <item name="background_drawable" type="id"/>

(...skipping 49 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
60 <item type="id" name="open_recently_closed_tab" />	60 <item type="id" name="open_recently_closed_tab" />

61	61

62 <!-- PaymentRequest -->	62 <!-- PaymentRequest -->

63 <item type="id" name="payments_section" />	63 <item type="id" name="payments_section" />

64 <item type="id" name="payments_left_summary_label" />	64 <item type="id" name="payments_left_summary_label" />

65 <item type="id" name="payments_first_radio_button" />	65 <item type="id" name="payments_first_radio_button" />

66 <item type="id" name="payments_add_option_button" />	66 <item type="id" name="payments_add_option_button" />

67 <item type="id" name="payments_edit_cancel_button" />	67 <item type="id" name="payments_edit_cancel_button" />

68 <item type="id" name="payments_edit_done_button" />	68 <item type="id" name="payments_edit_done_button" />

69 <item type="id" name="payments_edit_checkbox" />	69 <item type="id" name="payments_edit_checkbox" />

70	70 <item type="id" name="payments_open_editor_pencil_button" />
	Ian Wen 2016/12/09 22:17:53 Instead of giving it an ID at runtime, why not dec Instead of giving it an ID at runtime, why not declare it in payment_option_edit_icon.xml? This way you don't need to set it in Java. Mathieu 2016/12/09 22:57:10 Good idea, done Show quoted text On 2016/12/09 22:17:53, Ian Wen wrote: > Instead of giving it an ID at runtime, why not declare it in > payment_option_edit_icon.xml? This way you don't need to set it in Java. Good idea, done
	71

71 <!-- Password update prompt -->	72 <!-- Password update prompt -->

72 <item type="id" name="password_infobar_accounts_spinner" />	73 <item type="id" name="password_infobar_accounts_spinner" />

73 </resources>	74 </resources>

OLD	NEW

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java » ('j') | no next file with comments »