Changes view manager test to connect via shell

Changes view manager test to connect via shell

Previously code was linking with ViewManager, now I'm connecting
through the shell. As part of this I'm adding a general class that
should make it easy to connect to any server through the shell.

For the time being I'm making the shell explicitly link with the
viewmanager. Eventually that'll have to change.

BUG=365012
TEST=covered by tests
R=davemoore@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266937

[Ben Goodger (Google), 2014-04-28 19:21:08]

https://codereview.chromium.org/256133002/diff/40001/mojo/shell/context.cc
File mojo/shell/context.cc (right):

https://codereview.chromium.org/256133002/diff/40001/mojo/shell/context.cc#ne...
mojo/shell/context.cc:123: // TODO(sky): need a better way to find this. It
shouldn't be linked in.
this is related to mojo_view_manager being a component instead of a shared
library right? what was the issue that prevented it from being a shared lib
again?

[sky, 2014-04-28 21:16:05]

Updated to expose function to get a handle to shell on ServiceManager::TestAPI

https://codereview.chromium.org/256133002/diff/40001/mojo/shell/context.cc
File mojo/shell/context.cc (right):

https://codereview.chromium.org/256133002/diff/40001/mojo/shell/context.cc#ne...
mojo/shell/context.cc:123: // TODO(sky): need a better way to find this. It
shouldn't be linked in.
On 2014/04/28 19:21:09, Ben Goodger (Google) wrote:
> this is related to mojo_view_manager being a component instead of a shared
> library right? what was the issue that prevented it from being a shared lib
> again?

Things didn't work well when the rest of chrome was built as a static lib. I'll
revisit this separately.

[sky, 2014-04-28 21:37:32]

I didn't expose a Shell* as I worried about the threading implications.

  -Scott

On Mon, Apr 28, 2014 at 2:16 PM,  <sky@chromium.org> wrote:
> Updated to expose function to get a handle to shell on
> ServiceManager::TestAPI
>
>
>
> https://codereview.chromium.org/256133002/diff/40001/mojo/shell/context.cc
> File mojo/shell/context.cc (right):
>
>
https://codereview.chromium.org/256133002/diff/40001/mojo/shell/context.cc#ne...
> mojo/shell/context.cc:123: // TODO(sky): need a better way to find this.
> It shouldn't be linked in.
> On 2014/04/28 19:21:09, Ben Goodger (Google) wrote:
>>
>> this is related to mojo_view_manager being a component instead of a
>
> shared
>>
>> library right? what was the issue that prevented it from being a
>
> shared lib
>>
>> again?
>
>
> Things didn't work well when the rest of chrome was built as a static
> lib. I'll revisit this separately.
>
> https://codereview.chromium.org/256133002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[DaveMoore, 2014-04-28 22:40:53]

https://codereview.chromium.org/256133002/diff/60002/mojo/shell/shell_test_he...
File mojo/shell/shell_test_helper.cc (right):

https://codereview.chromium.org/256133002/diff/60002/mojo/shell/shell_test_he...
mojo/shell/shell_test_helper.cc:30: new
ServiceManager::TestAPI(state->context->service_manager()));
Why is the test_api instance retained? Isn't it just a transient thing?

[sky, 2014-04-28 22:47:06]

https://codereview.chromium.org/256133002/diff/60002/mojo/shell/shell_test_he...
File mojo/shell/shell_test_helper.cc (right):

https://codereview.chromium.org/256133002/diff/60002/mojo/shell/shell_test_he...
mojo/shell/shell_test_helper.cc:30: new
ServiceManager::TestAPI(state->context->service_manager()));
On 2014/04/28 22:40:54, DaveMoore wrote:
> Why is the test_api instance retained? Isn't it just a transient thing?

It owns the shell instance.

[DaveMoore, 2014-04-28 23:03:48]

lgtm

[sky, 2014-04-28 23:04:26]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-04-28 23:05:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/256133002/60002

[commit-bot: I haz the power, 2014-04-28 23:13:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 23:13:24]

Try jobs failed on following builders:
  tryserver.chromium on android_clang_dbg

[sky, 2014-04-28 23:21:12]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-04-28 23:21:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/256133002/80001

[commit-bot: I haz the power, 2014-04-29 00:13:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 00:13:06]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[sky, 2014-04-29 00:13:33]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-04-29 00:16:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/256133002/80001

[commit-bot: I haz the power, 2014-04-29 00:37:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 00:37:23]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[sky, 2014-04-29 01:59:01]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-04-29 01:59:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/256133002/80001

[commit-bot: I haz the power, 2014-04-29 03:13:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 03:13:01]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[sky, 2014-04-29 14:42:36]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-04-29 14:42:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/256133002/80001

[sky, 2014-04-29 14:59:13]

The CQ bit was unchecked by sky@chromium.org

[sky, 2014-04-29 15:23:29]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-04-29 15:24:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/256133002/100001

[sky, 2014-04-29 19:31:46]

Committed patchset #7 manually as r266937 (presubmit successful).