Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: content/browser/cache_storage/cache_storage_cache.cc

Issue 2561203003: Introduce ServiceWorkerCache.Response.HasDeprecatedURL UMA (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/cache_storage/cache_storage_cache.cc
diff --git a/content/browser/cache_storage/cache_storage_cache.cc b/content/browser/cache_storage/cache_storage_cache.cc
index 1f5767ab469cf6e4bc1a9a6d166cb13bd12d3587..4bc34fc14254e7551391b35590c1fcbfa5fee7e9 100644
--- a/content/browser/cache_storage/cache_storage_cache.cc
+++ b/content/browser/cache_storage/cache_storage_cache.cc
@@ -1403,7 +1403,9 @@ void CacheStorageCache::PopulateResponseMetadata(
ServiceWorkerResponse* response) {
std::unique_ptr<std::vector<GURL>> url_list =
base::MakeUnique<std::vector<GURL>>();
- // TODO(horo) Add UMA for the deprecated URL field.
+ // From Chrome 57, proto::CacheMetadata's url field was deprecated.
+ UMA_HISTOGRAM_BOOLEAN("ServiceWorkerCache.Response.HasDeprecatedURL",
+ metadata.response().has_url());
if (metadata.response().has_url()) {
url_list->push_back(GURL(metadata.response().url()));
} else {
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698