Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: components/cryptauth/ble/BUILD.gn

Issue 2561203002: Migrate weave-related classes from proximity_auth/ble to cryptauth/ble. (Closed)
Patch Set: Moved all general classes from proximity_auth to cryptauth. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cryptauth/DEPS ('k') | components/cryptauth/ble/OWNERS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cryptauth/ble/BUILD.gn
diff --git a/components/proximity_auth/ble/BUILD.gn b/components/cryptauth/ble/BUILD.gn
similarity index 66%
copy from components/proximity_auth/ble/BUILD.gn
copy to components/cryptauth/ble/BUILD.gn
index 8375506623696741221b02f55adc034a13d61c56..c5fd50932520f243e552f53c063738b36a912411 100644
--- a/components/proximity_auth/ble/BUILD.gn
+++ b/components/cryptauth/ble/BUILD.gn
@@ -8,12 +8,6 @@ static_library("ble") {
sources = [
"bluetooth_low_energy_characteristics_finder.cc",
"bluetooth_low_energy_characteristics_finder.h",
- "bluetooth_low_energy_connection.cc",
- "bluetooth_low_energy_connection.h",
- "bluetooth_low_energy_connection_finder.cc",
- "bluetooth_low_energy_connection_finder.h",
- "bluetooth_low_energy_device_whitelist.cc",
- "bluetooth_low_energy_device_whitelist.h",
"bluetooth_low_energy_weave_client_connection.cc",
"bluetooth_low_energy_weave_client_connection.h",
"bluetooth_low_energy_weave_defines.h",
@@ -23,21 +17,17 @@ static_library("ble") {
"bluetooth_low_energy_weave_packet_receiver.h",
"fake_wire_message.cc",
"fake_wire_message.h",
- "pref_names.cc",
- "pref_names.h",
"remote_attribute.h",
]
deps = [
"//base",
- "//components/cryptauth",
- "//components/prefs",
- "//components/proximity_auth/logging",
- # TODO(https://crbug.com/562683): This component has a circular dependency
- # with the root proximity auth target. It is whitelisted in that target for
+ # TODO (hansberry): This component has a circular dependency
+ # with the root cryptauth target. It is whitelisted in that target for
# includes.
- #"//components/proximity_auth",
+ # "//components/cryptauth",
Kyle Horimoto 2016/12/09 01:25:09 This is commented out, so let's just remove it.
Ryan Hansberry 2016/12/09 02:36:50 Done.
+ "//components/prefs",
"//device/bluetooth",
"//net",
]
@@ -51,9 +41,6 @@ source_set("unit_tests") {
testonly = true
sources = [
"bluetooth_low_energy_characteristics_finder_unittest.cc",
- "bluetooth_low_energy_connection_finder_unittest.cc",
- "bluetooth_low_energy_connection_unittest.cc",
- "bluetooth_low_energy_device_whitelist_unittest.cc",
"bluetooth_low_energy_weave_client_connection_unittest.cc",
"bluetooth_low_energy_weave_packet_generator_unittest.cc",
"bluetooth_low_energy_weave_packet_receiver_unittest.cc",
@@ -66,7 +53,6 @@ source_set("unit_tests") {
"//base/test:test_support",
"//components/cryptauth",
"//components/prefs:test_support",
- "//components/proximity_auth:test_support",
"//device/bluetooth:mocks",
"//testing/gmock",
"//testing/gtest",
« no previous file with comments | « components/cryptauth/DEPS ('k') | components/cryptauth/ble/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698