Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: components/cryptauth/BUILD.gn

Issue 2561203002: Migrate weave-related classes from proximity_auth/ble to cryptauth/ble. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cryptauth/DEPS » ('j') | components/cryptauth/DEPS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cryptauth/BUILD.gn
diff --git a/components/cryptauth/BUILD.gn b/components/cryptauth/BUILD.gn
index 1bfdc1ba76a2b72eb2defb411ac1c7bd877dfaba..811d78d1cf9e11f2b8ec162bd224015302696599 100644
--- a/components/cryptauth/BUILD.gn
+++ b/components/cryptauth/BUILD.gn
@@ -47,6 +47,7 @@ static_library("cryptauth") {
deps = [
"//base",
+ "//components/cryptauth/ble",
"//components/gcm_driver",
"//components/gcm_driver/common",
"//components/prefs",
@@ -59,6 +60,9 @@ static_library("cryptauth") {
public_deps = [
"//components/cryptauth/proto",
]
+
+ # TODO (hansberry): Resolve this.
+ allow_circular_includes_from = [ "//components/cryptauth/ble" ]
Kyle Horimoto 2016/12/08 21:52:40 What is your plan for resolving this and the other
Kyle Horimoto 2016/12/09 01:25:09 Ping.
Ryan Hansberry 2016/12/09 02:36:50 I see two ways to solve this: 1) Consolidate all
Kyle Horimoto 2016/12/09 18:07:46 Cool, those both sound reasonable. No need to do i
Ryan Hansberry 2016/12/09 20:11:05 Great. I'll do that right after this CL.
}
static_library("test_support") {
« no previous file with comments | « no previous file | components/cryptauth/DEPS » ('j') | components/cryptauth/DEPS » ('J')

Powered by Google App Engine
This is Rietveld 408576698