Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 2561173002: [Mac] Set the nsexception crash key in TERMINATING_FROM_UNCAUGHT_NSEXCEPTION(). (Closed)

Created:
4 years ago by Robert Sesek
Modified:
4 years ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Set the nsexception crash key in TERMINATING_FROM_UNCAUGHT_NSEXCEPTION(). This was set previously back when the NSException initializers were swizzled, and it can be used by the crash processor more easily than the first/lastexception keys. BUG=637270 R=mark@chromium.org Committed: https://crrev.com/b1c93f15d1f0d15a575b6b491e5d5ef536e5a1f1 Cr-Commit-Position: refs/heads/master@{#437350}

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/mac/exception_processor.mm View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Robert Sesek
4 years ago (2016-12-08 21:03:55 UTC) #11
Mark Mentovai
LGTM
4 years ago (2016-12-08 21:22:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561173002/40001
4 years ago (2016-12-08 21:23:04 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years ago (2016-12-08 21:34:55 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-08 21:38:05 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1c93f15d1f0d15a575b6b491e5d5ef536e5a1f1
Cr-Commit-Position: refs/heads/master@{#437350}

Powered by Google App Engine
This is Rietveld 408576698