Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2561083002: Reland Store OSR'd optimized code on the native context. (Closed)

Created:
4 years ago by mvstanton
Modified:
4 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, Yang, v8-ppc-ports_googlegroups.com, rmcilroy, Benedikt Meurer
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland Store OSR'd optimized code on the native context. The patch was reverted due to a bug - we failed to evict OSR-optimized code in the case where the SharedFunctionInfo OptimizedCodeMap was empty/cleared. Since we OSR code rarely, it makes sense to store it and look for it on the native context rather than the SharedFunctionInfo. This makes the OptimizedCodeMap data structure more space efficient, as it doesn't have to store an ast ID for the OSR entry point. Committed: https://crrev.com/044b2d1bd888dc19753f3717f362f90944614cc7 Cr-Commit-Position: refs/heads/master@{#41584}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -99 lines) Patch
M src/bootstrapper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/arm/builtins-arm.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/contexts.h View 2 chunks +22 lines, -0 lines 0 comments Download
M src/contexts.cc View 1 chunk +176 lines, -0 lines 0 comments Download
M src/contexts-inl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/debug/debug.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/isolate.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/objects.h View 3 chunks +3 lines, -7 lines 0 comments Download
M src/objects.cc View 6 chunks +43 lines, -53 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallRuntime.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/SuperCallAndSpread.golden View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
mvstanton
Hi Michael, Here is the reland of yesterday's CL with the bugfix in objects.cc included. ...
4 years ago (2016-12-08 10:41:26 UTC) #3
Michael Starzinger
LGTM (rubber-stamp, assuming it is a mechanical combination of the two CLs that I already ...
4 years ago (2016-12-08 10:42:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561083002/1
4 years ago (2016-12-08 10:47:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 11:13:36 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-08 11:14:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/044b2d1bd888dc19753f3717f362f90944614cc7
Cr-Commit-Position: refs/heads/master@{#41584}

Powered by Google App Engine
This is Rietveld 408576698