Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 2561063002: VEA unittest: fix cache line-alignment test hang issue (Closed)

Created:
4 years ago by hywu
Modified:
4 years ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VEA unittest: fix cache line-alignment test hang issue If VEA encoder fails to initialize because the driver detects plane size is unalign with cache line and returns VIDIOC_S_FMT error, the test hangs at waiting undefinitely in error state. This change makes the test to fail properly. BUG=672377 TEST=Run VEA unittest on Kevin. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/7446ca098616beb872dc93e88bf0b568bca61b16 Cr-Commit-Position: refs/heads/master@{#437455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M media/gpu/video_encode_accelerator_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
hywu1
4 years ago (2016-12-08 07:53:24 UTC) #3
kcwu
lgtm
4 years ago (2016-12-08 08:36:22 UTC) #4
wuchengli
lgtm
4 years ago (2016-12-08 09:30:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561063002/1
4 years ago (2016-12-09 03:40:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 03:46:20 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-09 03:48:50 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7446ca098616beb872dc93e88bf0b568bca61b16
Cr-Commit-Position: refs/heads/master@{#437455}

Powered by Google App Engine
This is Rietveld 408576698