Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: components/safe_browsing_db/v4_feature_list.cc

Issue 2561053002: V4Only: In V4Only mode use PVer4 for all SafeBrowsing operations (Closed)
Patch Set: Fix my comments from 2533993004 Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db/v4_feature_list.cc
diff --git a/components/safe_browsing_db/v4_feature_list.cc b/components/safe_browsing_db/v4_feature_list.cc
index 9f33f9fae92fe8af64cc70169b200eb76033b1ab..323ad4db74f396de0e85e3b07dd198e6735764ec 100644
--- a/components/safe_browsing_db/v4_feature_list.cc
+++ b/components/safe_browsing_db/v4_feature_list.cc
@@ -17,17 +17,26 @@ const base::Feature kLocalDatabaseManagerEnabled{
const base::Feature kV4HybridEnabled{"SafeBrowsingV4HybridEnabled",
base::FEATURE_DISABLED_BY_DEFAULT};
+const base::Feature kV4OnlyEnabled{"SafeBrowsingV4OnlyEnabled",
+ base::FEATURE_DISABLED_BY_DEFAULT};
+
} // namespace
bool IsLocalDatabaseManagerEnabled() {
return base::FeatureList::IsEnabled(kLocalDatabaseManagerEnabled) ||
- IsV4HybridEnabled();
+ IsV4HybridEnabled() || IsV4OnlyEnabled();
}
bool IsV4HybridEnabled() {
return base::FeatureList::IsEnabled(kV4HybridEnabled);
}
+bool IsV4OnlyEnabled() {
+ // TODO(vakh): Enable this only when all the lists can be synced from the
+ // server. See http://b/33182208
+ return base::FeatureList::IsEnabled(kV4OnlyEnabled);
+}
+
} // namespace V4FeatureList
} // namespace safe_browsing

Powered by Google App Engine
This is Rietveld 408576698