third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp - Issue 2561043002: Clean-up after Form Association Refactoring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp

Issue 2561043002: Clean-up after Form Association Refactoring (Closed)

Patch Set: Removed constructorNeedsFormElement from scripts and HTMLTagNames Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/forms/FileInputTypeTest.cpp ('k') | third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp b/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp

index c14205ed362668a2ff0c5168a02f709639dc24a4..51f38d8471e7bf6ebe03660a4ec7552d6584d313 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp

@@ -936,8 +936,8 @@ HTMLElement* HTMLConstructionSite::createHTMLElement(AtomicHTMLToken* token) {

// FIXME: This can't use HTMLConstructionSite::createElement because we have

// to pass the current form element. We should rework form association to

// occur after construction to allow better code sharing here.

- element = HTMLElementFactory::createHTMLElement(

- token->name(), document, form, getCreateElementFlags());

+ element = HTMLElementFactory::createHTMLElement(token->name(), document,

+ getCreateElementFlags());

if (FormAssociated* formAssociatedElement =

element->toFormAssociatedOrNull()) {

formAssociatedElement->associateWith(form);