third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp - Issue 2561043002: Clean-up after Form Association Refactoring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

Issue 2561043002: Clean-up after Form Association Refactoring (Closed)

Patch Set: Remove redundant code path/arguments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLTextAreaElement.h ('K') | « third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp ('k') | third_party/WebKit/Source/web/WebHelperPluginImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

index 290dd313868f7aa32a3330c282f8816fb9343282..937d7826237e9efff25ee864f6426624fc03922d 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

@@ -528,7 +528,7 @@ Element* MediaControlTextTrackListElement::createTextTrackListItem(

trackItem->setShadowPseudoId(

AtomicString("-internal-media-controls-text-track-list-item"));

HTMLInputElement* trackItemInput =

- HTMLInputElement::create(document(), nullptr, false);

+ HTMLInputElement::create(document(), false);

trackItemInput->setShadowPseudoId(

AtomicString("-internal-media-controls-text-track-list-item-input"));

trackItemInput->setType(InputTypeNames::checkbox);