Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 2561043002: Clean-up after Form Association Refactoring (Closed)
Patch Set: Remove redundant code path/arguments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
index 0c46c5a84fb52f507ce7b5e4c013cf3bace05422..2bfe488d7989e61865b059a5c649ee2de87bbb41 100644
--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
@@ -85,8 +85,8 @@ using namespace HTMLNames;
// signed.
static const unsigned maxListItems = INT_MAX;
-HTMLSelectElement::HTMLSelectElement(Document& document, HTMLFormElement* form)
- : HTMLFormControlElementWithState(selectTag, document, form),
+HTMLSelectElement::HTMLSelectElement(Document& document)
+ : HTMLFormControlElementWithState(selectTag, document),
m_typeAhead(this),
m_size(0),
m_lastOnChangeOption(nullptr),
@@ -100,14 +100,7 @@ HTMLSelectElement::HTMLSelectElement(Document& document, HTMLFormElement* form)
}
HTMLSelectElement* HTMLSelectElement::create(Document& document) {
- HTMLSelectElement* select = new HTMLSelectElement(document, 0);
- select->ensureUserAgentShadowRoot();
- return select;
-}
-
-HTMLSelectElement* HTMLSelectElement::create(Document& document,
- HTMLFormElement* form) {
- HTMLSelectElement* select = new HTMLSelectElement(document, form);
+ HTMLSelectElement* select = new HTMLSelectElement(document);
select->ensureUserAgentShadowRoot();
return select;
}

Powered by Google App Engine
This is Rietveld 408576698