Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 256103006: Undo the changes to LabelButton from r266097 (Closed)

Created:
6 years, 7 months ago by Evan Stade
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Undo the changes to LabelButton from r266097 This caused breakage because many places create a LabelButton then call SetBorder. By calling SetBorder whenever the NativeTheme changes, the custom border is overridden. BUG=367614, 367625, 367607 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266736

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/views/controls/button/label_button.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Evan Stade
revert first, fix Linux Aura later.
6 years, 7 months ago (2014-04-28 19:44:39 UTC) #1
sky
LGTM
6 years, 7 months ago (2014-04-28 20:40:59 UTC) #2
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 7 months ago (2014-04-28 21:54:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/256103006/1
6 years, 7 months ago (2014-04-28 21:55:30 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 22:38:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 7 months ago (2014-04-28 22:38:46 UTC) #6
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 7 months ago (2014-04-28 22:52:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/256103006/1
6 years, 7 months ago (2014-04-28 22:52:39 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 02:00:27 UTC) #9
Message was sent while issue was closed.
Change committed as 266736

Powered by Google App Engine
This is Rietveld 408576698