Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 256103005: [Android]: Don't redefine timegm on arm64. (Closed)

Created:
6 years, 7 months ago by Primiano Tucci (use gerrit)
Modified:
6 years, 7 months ago
Reviewers:
Mark Mentovai, rmcilroy
CC:
chromium-reviews, erikwright+watch_chromium.org, Torne, enh
Visibility:
Public.

Description

[Android]: Don't redefine timegm on arm64. The latest Android NDK finally provides a timegm implementation. No need to re-define in the compat layer anymore for 64-bit devices. BUG=366054, 354405 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266706

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M base/os_compat_android.cc View 1 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Primiano Tucci (use gerrit)
This is essentially a follow-up to crrev.com/249263002 I think that CL genuinely missed this other ...
6 years, 7 months ago (2014-04-28 18:48:25 UTC) #1
rmcilroy
On 2014/04/28 18:48:25, Primiano Tucci wrote: > This is essentially a follow-up to crrev.com/249263002 > ...
6 years, 7 months ago (2014-04-28 18:53:39 UTC) #2
Mark Mentovai
LGTM otherwise. Thanks! https://codereview.chromium.org/256103005/diff/1/base/os_compat_android.cc File base/os_compat_android.cc (right): https://codereview.chromium.org/256103005/diff/1/base/os_compat_android.cc#newcode44 base/os_compat_android.cc:44: // Android has only timegm64() and ...
6 years, 7 months ago (2014-04-28 18:56:26 UTC) #3
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 7 months ago (2014-04-28 19:02:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/256103005/20001
6 years, 7 months ago (2014-04-28 19:02:53 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 19:10:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 7 months ago (2014-04-28 19:10:38 UTC) #7
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 7 months ago (2014-04-28 19:25:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/256103005/20001
6 years, 7 months ago (2014-04-28 19:26:28 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 00:06:00 UTC) #10
Message was sent while issue was closed.
Change committed as 266706

Powered by Google App Engine
This is Rietveld 408576698