Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: chrome/browser/chromeos/arc/optin/arc_terms_of_service_negotiator.h

Issue 2561023002: arc: ARC loading progress should not be shown when started from OOBE. (Closed)
Patch Set: rebased + comments updated Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/optin/arc_terms_of_service_negotiator.h
diff --git a/chrome/browser/chromeos/arc/optin/arc_terms_of_service_negotiator.h b/chrome/browser/chromeos/arc/optin/arc_terms_of_service_negotiator.h
index 41871dde0650cd555c942837cb825cf9b71e3246..53adadbe815989cf8e10b36cd013b29936711cac 100644
--- a/chrome/browser/chromeos/arc/optin/arc_terms_of_service_negotiator.h
+++ b/chrome/browser/chromeos/arc/optin/arc_terms_of_service_negotiator.h
@@ -5,58 +5,34 @@
#ifndef CHROME_BROWSER_CHROMEOS_ARC_OPTIN_ARC_TERMS_OF_SERVICE_NEGOTIATOR_H_
#define CHROME_BROWSER_CHROMEOS_ARC_OPTIN_ARC_TERMS_OF_SERVICE_NEGOTIATOR_H_
-#include <memory>
-#include <string>
-
#include "base/callback.h"
#include "base/macros.h"
-#include "chrome/browser/chromeos/arc/arc_support_host.h"
-#include "chrome/browser/chromeos/arc/optin/arc_optin_preference_handler_observer.h"
-
-class PrefService;
namespace arc {
-class ArcOptInPreferenceHandler;
-
-// Handles the Terms-of-service agreement user action.
-class ArcTermsOfServiceNegotiator : public ArcSupportHost::Observer,
- public ArcOptInPreferenceHandlerObserver {
+// Interface to handle the Terms-of-service agreement user action.
+class ArcTermsOfServiceNegotiator {
public:
- ArcTermsOfServiceNegotiator(PrefService* pref_service,
- ArcSupportHost* support_host);
- ~ArcTermsOfServiceNegotiator() override;
+ ArcTermsOfServiceNegotiator();
+ virtual ~ArcTermsOfServiceNegotiator();
- // Shows "Terms of service" page on ARC support Chrome App. Invokes the
- // |callback| asynchronously with "|agreed| = true" if user agrees it.
- // Otherwise (e.g., user clicks "Cancel" or closes the window), invokes
- // |callback| with |agreed| = false.
- // Deleting this instance cancels the operation, so |callback| will never
- // be invoked then.
+ // Invokes the|callback| asynchronously with "|accepted| = true" if user
+ // accepts ToS. If user explicitly rejects ToS, invokes |callback| with
+ // |accepted| = false. Deleting this instance cancels the operation, so
+ // |callback| will never be invoked then.
using NegotiationCallback = base::Callback<void(bool accepted)>;
void StartNegotiation(const NegotiationCallback& callback);
- private:
- // ArcSupportHost::Observer:
- void OnWindowClosed() override;
- void OnTermsAgreed(bool is_metrics_enabled,
- bool is_backup_and_restore_enabled,
- bool is_location_service_enabled) override;
- void OnAuthSucceeded(const std::string& auth_code) override;
- void OnRetryClicked() override;
- void OnSendFeedbackClicked() override;
-
- // ArcOptInPreferenceHandlerObserver:
- void OnMetricsModeChanged(bool enabled, bool managed) override;
- void OnBackupAndRestoreModeChanged(bool enabled, bool managed) override;
- void OnLocationServicesModeChanged(bool enabled, bool managed) override;
+ protected:
+ // Reports result of negotiation via callback and then resets it. If
+ // |accepted| is true then this means terms of service were accepted.
+ void ReportResult(bool accepted);
- PrefService* const pref_service_;
- // Owned by ArcSessionManager.
- ArcSupportHost* const support_host_;
+ private:
+ // Performs implementation specific action to start negotiation.
+ virtual void StartNegotiationImpl() = 0;
NegotiationCallback pending_callback_;
- std::unique_ptr<ArcOptInPreferenceHandler> preference_handler_;
DISALLOW_COPY_AND_ASSIGN(ArcTermsOfServiceNegotiator);
};

Powered by Google App Engine
This is Rietveld 408576698