arc: ARC loading progress should not be shown when started from OOBE.

chrome/browser/chromeos/arc/arc_support_host.h

Index: chrome/browser/chromeos/arc/arc_support_host.h
diff --git a/chrome/browser/chromeos/arc/arc_support_host.h b/chrome/browser/chromeos/arc/arc_support_host.h
index 9a33c41a17166439747d8b4cd5e7df56e72940a2..4bcc4f3e8153f54a8fc745c968a0b2538ad8f0ac 100644
--- a/chrome/browser/chromeos/arc/arc_support_host.h
+++ b/chrome/browser/chromeos/arc/arc_support_host.h
@@ -52,9 +52,9 @@ class ArcSupportHost : public arc::ArcSupportMessageHost::Observer,
     virtual void OnWindowClosed() {}
 
     // Called when the user press AGREE button on ToS page.
-    virtual void OnTermsAgreed(bool is_metrics_enabled,
-                               bool is_backup_and_restore_enabled,
-                               bool is_location_service_enabled) {}
+    virtual void OnTermsAccepted(bool is_metrics_enabled,

[hidehiko, 2016/12/20 15:20:45]

Thank you for the refactoring. Could you make another CL to do this, to make the
focus clearer?

[khmel, 2016/12/20 16:27:58]

If we are renaming comments in this CL why not to rename methods as well.
Otherwise we have to rename both in separate CL.

+                                 bool is_backup_and_restore_enabled,
+                                 bool is_location_service_enabled) {}
 
     // Called when LSO auth token fetch is successfully completed.
     virtual void OnAuthSucceeded(const std::string& auth_code) {}
@@ -101,8 +101,11 @@ class ArcSupportHost : public arc::ArcSupportMessageHost::Observer,
   // Requests to show the LSO page.
   void ShowLso();
 
-  // Requests to show the "ARC is loading" page.
-  void ShowArcLoading();
+  // Requests to show the "ARC is loading" page. If |force_activate| is set to
+  // true and UI is not shown this call activates UI first. If |force_activate|
+  // is set to false then this call does not activate UI and stores ui_page_
+  // state only.
+  void ShowArcLoading(bool force_activate);

[hidehiko, 2016/12/20 15:20:45]

The flag looks unnecessary complexity to me. Client code can control whether it
really needs to show the loading page or not.
I guess, you introduced this not to touch the |message_host_| outside of this
class, but in this class. However, it is what we should avoid to check the
member to decide whether loading page should be shown or not.

Please see also my comments in .cc file, too.

[khmel, 2016/12/20 16:27:58]

Responded in cc file.

 
   // Requests to show the error page
   void ShowError(Error error, bool should_show_send_feedback);