arc: ARC loading progress should not be shown when started from OOBE.

chrome/browser/chromeos/login/screens/arc_terms_of_service_screen_actor_observer.h

Index: chrome/browser/chromeos/login/screens/arc_terms_of_service_screen_actor_observer.h
diff --git a/chrome/browser/chromeos/login/screens/arc_terms_of_service_screen_actor_observer.h b/chrome/browser/chromeos/login/screens/arc_terms_of_service_screen_actor_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..cd1346eea25754d2be45fd453c3ec0b8f5181531
--- /dev/null
+++ b/chrome/browser/chromeos/login/screens/arc_terms_of_service_screen_actor_observer.h
@@ -0,0 +1,36 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_ARC_TERMS_OF_SERVICE_SCREEN_ACTOR_OBSERVER_H_
+#define CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_ARC_TERMS_OF_SERVICE_SCREEN_ACTOR_OBSERVER_H_
+
+#include "base/macros.h"
+
+namespace chromeos {
+
+class ArcTermsOfServiceScreenActor;
+
+class ArcTermsOfServiceScreenActorObserver {

[hidehiko, 2016/12/16 05:31:51]

Class document please.

[khmel, 2016/12/16 18:37:55]

Done.

+ public:
+  virtual ~ArcTermsOfServiceScreenActorObserver() = default;
+
+  // Called when the user skips the PlayStore Terms of Service.
+  virtual void OnSkip() = 0;
+
+  // Called when the user accepts the PlayStore Terms of Service.
+  virtual void OnAccept() = 0;
+
+  // Called when actor is destroyed so there is no dead reference to it.
+  virtual void OnActorDestroyed(ArcTermsOfServiceScreenActor* actor) = 0;
+
+ protected:
+  ArcTermsOfServiceScreenActorObserver() = default;

[hidehiko, 2016/12/16 05:31:51]

You can remove this.
this Observer cannot be directly instantiated because of pure virtual methods.

[khmel, 2016/12/16 18:37:55]

It is required due:

../../chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.cc:18:26:
error: constructor for 'chromeos::ArcTermsOfServiceScreen' must explicitly
initialize the base class 'chromeos::ArcTermsOfServiceScreenActorObserver' which
does not have a default constructor

[hidehiko, 2016/12/19 15:49:44]

Ah, I see.
Optional: alternative is removing DISALLOW_COPY_AND_ASSIGN from this interface,
and let implement classes decide it. Up to you.

[khmel, 2016/12/19 17:48:10]

Noted, thanks for hint

+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ArcTermsOfServiceScreenActorObserver);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_ARC_TERMS_OF_SERVICE_SCREEN_ACTOR_OBSERVER_H_