arc: ARC loading progress should not be shown when started from OOBE.

chrome/browser/chromeos/arc/arc_support_host.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/arc/arc_support_host.h"
 
 #include <string>
 #include <utility>
 
 #include "ash/common/system/chromeos/devicetype_utils.h"
@@ skipping 201 matching lines @@
 
 void ArcSupportHost::ShowPage(UIPage ui_page) {
   ui_page_ = ui_page;
   if (!message_host_) {
     if (app_start_pending_) {
       VLOG(2) << "ArcSupportHost::ShowPage(" << ui_page << ") is called "
               << "before connection to ARC support Chrome app has finished "
               << "establishing.";
       return;
     }
-    RequestAppStart();
+
+    if (!silent_mode_ || ui_page != UIPage::ARC_LOADING)
+      RequestAppStart();
+    else
+      VLOG(2) << "Skip showing Arc loading progess due in silent mode.";
+
     return;
   }
 
   base::DictionaryValue message;
   message.SetString(kAction, kActionShowPage);
   switch (ui_page) {
     case UIPage::TERMS:
       message.SetString(kPage, "terms");
       break;
     case UIPage::LSO:
@@ skipping 141 matching lines @@
   display::Screen* screen = display::Screen::GetScreen();
   if (screen)
     screen->RemoveObserver(this);
   message_host_->SetObserver(nullptr);
   message_host_ = nullptr;
 }
 
 void ArcSupportHost::RequestAppStart() {
   DCHECK(!message_host_);
   DCHECK(!app_start_pending_);
-
+  silent_mode_ = false;
   app_start_pending_ = true;
   request_open_app_callback_.Run(profile_);
 }
 
 void ArcSupportHost::SetRequestOpenAppCallbackForTesting(
     const RequestOpenAppCallback& callback) {
   DCHECK(!message_host_);
   DCHECK(!app_start_pending_);
   DCHECK(!callback.is_null());
   request_open_app_callback_ = callback;
@@ skipping 89 matching lines @@
   message.Set(kData, std::move(loadtime_data));
 
   const std::string device_id = user_manager::known_user::GetDeviceId(
       multi_user_util::GetAccountIdFromProfile(profile_));
   message.SetString(kDeviceId, device_id);
 
   message_host_->SendMessage(message);
   return true;
 }
 
+void ArcSupportHost::SetSilentMode() {
+  if (message_host_) {
+    // In case of managed Arc, UI is started OnPrimaryProfilePrepared which

[xiyuan, 2016/12/08 20:27:28]

nit: OnPrimaryProfilePrepared -> OnPrimary*User*ProfilePrepared

[khmel, 2016/12/08 23:33:45]

Done.

+    // happens earlier than user processes Arc OOBE page. Close UI manually in
+    // this case.
+    DCHECK(ui_page_ == UIPage::ARC_LOADING || ui_page_ == UIPage::TERMS);
+    Close();

[xiyuan, 2016/12/08 20:27:28]

Is it possible to not open the UI at all instead of closing it here? e.g.
integrate with ArcTermsOfServiceNegotiator so that it knows we are showing OOBE
ToS ?

[khmel, 2016/12/08 23:33:45]

Yes, not opening is preferred. However found yet another problem. In case Arc
managed enabled hiding OptIn does not have effect, because pref is not changed.
I think it is better to analyze first run flag and listen for terms accepted
change. OnPrimaryUserProfile is actually called before showing Arc OOBE. Could
you PTAL to new variant? In this case we don't need to signal anything from OOBE
and we have loose coupling here.

WDYT?

+  }
+  silent_mode_ = true;
+}
+
 void ArcSupportHost::OnDisplayAdded(const display::Display& new_display) {}
 
 void ArcSupportHost::OnDisplayRemoved(const display::Display& old_display) {}
 
 void ArcSupportHost::OnDisplayMetricsChanged(const display::Display& display,
                                              uint32_t changed_metrics) {
   if (!message_host_)
     return;
 
   base::DictionaryValue message;
@@ skipping 39 matching lines @@
     for (auto& observer : observer_list_)
       observer.OnRetryClicked();
   } else if (event == kEventOnSendFeedbackClicked) {
     for (auto& observer : observer_list_)
       observer.OnSendFeedbackClicked();
   } else {
     LOG(ERROR) << "Unknown message: " << event;
     NOTREACHED();
   }
 }