arc: ARC loading progress should not be shown when started from OOBE.

chrome/browser/chromeos/arc/arc_session_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_ARC_ARC_SESSION_MANAGER_H_
 #define CHROME_BROWSER_CHROMEOS_ARC_ARC_SESSION_MANAGER_H_
 
 #include <memory>
 #include <ostream>
 #include <string>
@@ skipping 60 matching lines @@
   //
   // State transition should be as follows:
   //
   // NOT_INITIALIZED -> STOPPED: when the primary Profile gets ready.
   // ...(any)... -> NOT_INITIALIZED: when the Chrome is being shutdown.
   // ...(any)... -> STOPPED: on error.
   //
   // In the first boot case (no OOBE case):
   //   STOPPED -> SHOWING_TERMS_OF_SERVICE: when arc.enabled preference is set.
   //   SHOWING_TERMS_OF_SERVICE -> CHECKING_ANDROID_MANAGEMENT: when a user
-  //     agree with "Terms Of Service"
+  //     accepts "Terms Of Service"

[hidehiko, 2016/12/20 15:20:45]

Wow, thanks!

[khmel, 2016/12/20 16:27:58]

Acknowledged.

   //   CHECKING_ANDROID_MANAGEMENT -> FETCHING_CODE: when Android management
   //     check passes.
   //   FETCHING_CODE -> ACTIVE: when the auth token is successfully fetched.
   //
   // In the first boot case (OOBE case):
   //   STOPPED -> FETCHING_CODE: When arc.enabled preference is set.
   //   FETCHING_CODE -> ACTIVE: when the auth token is successfully fetched.
   //
   // In the second (or later) boot case:
   //   STOPPED -> ACTIVE: when arc.enabled preference is checked that it is
@@ skipping 80 matching lines @@
   void RecordArcState();
 
   // sync_preferences::PrefServiceSyncableObserver
   void OnIsSyncingChanged() override;
 
   // sync_preferences::SyncedPrefObserver
   void OnSyncedPrefChanged(const std::string& path, bool from_sync) override;
 
   // ArcSupportHost::Observer:
   void OnWindowClosed() override;
-  void OnTermsAgreed(bool is_metrics_enabled,
-                     bool is_backup_and_restore_enabled,
-                     bool is_location_service_enabled) override;
+  void OnTermsAccepted(bool is_metrics_enabled,
+                       bool is_backup_and_restore_enabled,
+                       bool is_location_service_enabled) override;
   void OnRetryClicked() override;
   void OnSendFeedbackClicked() override;
 
   // Stops ARC without changing ArcEnabled preference.
   void StopArc();
 
   // StopArc(), then EnableArc(). Between them data clear may happens.
   // This is a special method to support enterprise device lost case.
   // This can be called only when ARC is running.
   void StopAndEnableArc();
 
   // Removes the data if ARC is stopped. Otherwise, queue to remove the data
   // on ARC is stopped.
   void RemoveArcData();
 
   ArcSupportHost* support_host() { return support_host_.get(); }
 
   // TODO(hidehiko): Get rid of the getter by migration between ArcAuthContext
   // and ArcAuthCodeFetcher.
   ArcAuthContext* auth_context() { return context_.get(); }
 
   void StartArc();
 
   void OnProvisioningFinished(ProvisioningResult result);
 
   void SetAttemptUserExitCallbackForTesting(const base::Closure& callback);
 
  private:
   // Negotiates the terms of service to user.
-  void StartTermsOfServiceNegotiation();
+  void StartTermsOfServiceNegotiation(bool initial_run);
   void OnTermsOfServiceNegotiated(bool accepted);
 
   void SetState(State state);
   void ShutdownBridge();
-  void OnOptInPreferenceChanged();
+  void OnOptInPreferenceChanged(bool initial_run);
   void OnAndroidManagementPassed();
   void OnArcDataRemoved(bool success);
   void OnArcSignInTimeout();
   void FetchAuthCode();
   void PrepareContextForAuthCodeRequest();
 
   void StartArcAndroidManagementCheck();
   void MaybeReenableArc();
 
   // Called when the Android management check is done in opt-in flow or
@@ skipping 34 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(ArcSessionManager);
 };
 
 // Outputs the stringified |state| to |os|. This is only for logging purposes.
 std::ostream& operator<<(std::ostream& os,
                          const ArcSessionManager::State& state);
 
 }  // namespace arc
 
 #endif  // CHROME_BROWSER_CHROMEOS_ARC_ARC_SESSION_MANAGER_H_