arc: ARC loading progress should not be shown when started from OOBE.

chrome/browser/chromeos/arc/arc_support_host.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_ARC_ARC_SUPPORT_HOST_H_
 #define CHROME_BROWSER_CHROMEOS_ARC_ARC_SUPPORT_HOST_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 107 matching lines @@
   void OnDisplayAdded(const display::Display& new_display) override;
   void OnDisplayRemoved(const display::Display& old_display) override;
   void OnDisplayMetricsChanged(const display::Display& display,
                                uint32_t changed_metrics) override;
 
   // Returns current page that has to be shown in OptIn UI.
   // Note that this can be inconsistent from the actually shown page.
   // TODO(hidehiko): Remove this exposure.
   UIPage ui_page() const { return ui_page_; }
 
+  // Returns true if message host is currently attached which means UI is shown.
+  bool has_message_host() const { return message_host_; }

[hidehiko, 2016/12/16 05:31:50]

Please do not expose anything about related to message_host_.
It is asynchronously connected, and this class is wrapping it to encapsulates
the asynchronous-ness.
IIUC, you do not need anymore?

[khmel, 2016/12/16 18:37:55]

It is needed, please see void ArcSessionManager::OnTermsOfServiceNegotiated(bool
accepted). This method starts Arc Loading progress. It is required for default
case but not required for OOBE case.

[hidehiko, 2016/12/19 15:49:44]

Oh I see. Then please use ui_page_, instead, for the page transition tracking.
Considering that we do want to remove it directly, maybe we'd like to have
another accessor, e.g. IsWindowOpened(), with comment about the timing issue
(the actual window opening/closing may be delayed).

[khmel, 2016/12/19 17:48:10]

I added parameter force_activate to ShowArcLoading. Hope this would work better.

+
   void SetRequestOpenAppCallbackForTesting(
       const RequestOpenAppCallback& callback);
 
  private:
   struct PreferenceCheckboxData {
     PreferenceCheckboxData() : PreferenceCheckboxData(false, false) {}
     PreferenceCheckboxData(bool is_enabled, bool is_managed)
         : is_enabled(is_enabled), is_managed(is_managed) {}
 
     bool is_enabled;
@@ skipping 45 matching lines @@
   bool is_arc_managed_ = false;
 
   PreferenceCheckboxData metrics_checkbox_;
   PreferenceCheckboxData backup_and_restore_checkbox_;
   PreferenceCheckboxData location_services_checkbox_;
 
   DISALLOW_COPY_AND_ASSIGN(ArcSupportHost);
 };
 
 #endif  // CHROME_BROWSER_CHROMEOS_ARC_ARC_SUPPORT_HOST_H_