Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2561001: Fix LoadKernel() (Closed)

Created:
10 years, 6 months ago by Randall Spangler
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://gitrw.chromium.org/chromiumos
Visibility:
Public.

Description

fixed VerifyKernelHeader removed extra debugging fixed printf() format specifiers

Patch Set 1 #

Patch Set 2 : Fix printf() calls #

Patch Set 3 : Fixed debug output #

Patch Set 4 : Fixed autotest build #

Total comments: 4

Patch Set 5 : Make requested changes. Rename bootloader start to bootloader address. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -32 lines) Patch
M src/platform/vboot_reference/utility/Makefile View 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/platform/vboot_reference/utility/load_kernel_test.c View 1 2 3 4 6 chunks +40 lines, -12 lines 0 comments Download
M src/platform/vboot_reference/vboot_firmware/include/kernel_image_fw.h View 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M src/platform/vboot_reference/vboot_firmware/include/load_kernel_fw.h View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/vboot_reference/vboot_firmware/lib/kernel_image_fw.c View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M src/platform/vboot_reference/vboot_firmware/lib/load_kernel_fw.c View 1 2 3 4 9 chunks +21 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Randall Spangler
10 years, 6 months ago (2010-06-03 06:03:48 UTC) #1
gauravsh
10 years, 6 months ago (2010-06-03 07:47:52 UTC) #2
lgtm with comments

http://codereview.chromium.org/2561001/diff/7001/8002
File src/platform/vboot_reference/utility/load_kernel_test.c (right):

http://codereview.chromium.org/2561001/diff/7001/8002#newcode6
src/platform/vboot_reference/utility/load_kernel_test.c:6: /* Routines for
verifying a file's signature. Useful in testing the core
Fix comment?

http://codereview.chromium.org/2561001/diff/7001/8002#newcode10
src/platform/vboot_reference/utility/load_kernel_test.c:10: #include
<inttypes.h>
use <stdint.h> instead since that's more standard

http://codereview.chromium.org/2561001/diff/7001/8002#newcode96
src/platform/vboot_reference/utility/load_kernel_test.c:96: /* Read header
signing key blob */
There's BufferFromFIle() which you can use to do this instead. It also returns
the size of the read file.

http://codereview.chromium.org/2561001/diff/7001/8005
File src/platform/vboot_reference/vboot_firmware/lib/load_kernel_fw.c (right):

http://codereview.chromium.org/2561001/diff/7001/8005#newcode21
src/platform/vboot_reference/vboot_firmware/lib/load_kernel_fw.c:21: #include
<inttypes.h>
<stdint.h>

Powered by Google App Engine
This is Rietveld 408576698