[Mac] Fix omnibox text overlap

[Mac] Fix omnibox text overlap

Remove the extra white left padding of the AutocompleteTextField.

BUG=669870

[spqchan, 2016-12-08 00:30:20]

Description was changed from

==========
[Mac] Fix omnibox text overlap

- Remove the white padding on the left of AutocompleteTextField

BUG=
==========

to

==========
[Mac] Fix omnibox text overlap

- Remove the white padding on the left of AutocompleteTextField

BUG=669870
==========

[spqchan, 2016-12-08 00:30:43]

Description was changed from

==========
[Mac] Fix omnibox text overlap

- Remove the white padding on the left of AutocompleteTextField

BUG=669870
==========

to

==========
[Mac] Fix omnibox text overlap

Remove the extra white left padding of the AutocompleteTextField.

BUG=669870
==========

[spqchan, 2016-12-08 00:30:43]

spqchan@chromium.org changed reviewers:
+ shrike@chromium.org

[spqchan, 2016-12-08 00:30:47]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[spqchan, 2016-12-08 00:30:53]

PTAL

[commit-bot: I haz the power, 2016-12-08 00:31:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 00:49:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 00:49:07]

Dry run: This issue passed the CQ dry run.

[shrike, 2016-12-08 01:07:28]

I recently suggested a fix for this - I hadn't checked my e-mail in awhile and
so did not see your cl. I think my suggested fix will be simpler?

[spqchan, 2016-12-08 03:51:02]

On 2016/12/08 01:07:28, shrike wrote:
> I recently suggested a fix for this - I hadn't checked my e-mail in awhile and
> so did not see your cl. I think my suggested fix will be simpler?

Thanks for the suggestion! It's definitely simpler and something that'll be
useful for the future.
Unfortunately, the omnibox drawing is a bit complex for that to be applicable =/
Using cliprect will clip out the left edge of the omnibox, not the left padding
with the text

[shrike, 2016-12-08 17:01:39]

On 2016/12/08 03:51:02, spqchan wrote:
> Thanks for the suggestion! It's definitely simpler and something that'll be
> useful for the future.
> Unfortunately, the omnibox drawing is a bit complex for that to be applicable
=/
> Using cliprect will clip out the left edge of the omnibox, not the left
padding
> with the text

Have you narrowed down the method that is doing the unwanted drawing?

[spqchan, 2016-12-08 18:25:46]

On 2016/12/08 17:01:39, shrike wrote:
> On 2016/12/08 03:51:02, spqchan wrote:
> > Thanks for the suggestion! It's definitely simpler and something that'll be
> > useful for the future.
> > Unfortunately, the omnibox drawing is a bit complex for that to be
applicable
> =/
> > Using cliprect will clip out the left edge of the omnibox, not the left
> padding
> > with the text
> 
> Have you narrowed down the method that is doing the unwanted drawing?

That's a good point. AFAIK, the method doing the unwanted drawing is
AutocompleteTextfieldCell's drawInteriorWithFrame and
AutocompleteTextFieldEditor's drawRect
Here's my attempt: https://codereview.chromium.org/2563713002/

It clips for AutocompleteTextFieldEditor, we just need to shift the textview to
the left.
If doesn't work out for AutocompleteTextfieldCell. Perhaps I am missing
something?

[shrike, 2016-12-08 20:14:25]

On 2016/12/08 18:25:46, spqchan wrote:
> On 2016/12/08 17:01:39, shrike wrote:
> > On 2016/12/08 03:51:02, spqchan wrote:
> > > Thanks for the suggestion! It's definitely simpler and something that'll
be
> > > useful for the future.
> > > Unfortunately, the omnibox drawing is a bit complex for that to be
> applicable
> > =/
> > > Using cliprect will clip out the left edge of the omnibox, not the left
> > padding
> > > with the text
> > 
> > Have you narrowed down the method that is doing the unwanted drawing?
> 
> That's a good point. AFAIK, the method doing the unwanted drawing is
> AutocompleteTextfieldCell's drawInteriorWithFrame and
> AutocompleteTextFieldEditor's drawRect
> Here's my attempt: https://codereview.chromium.org/2563713002/
> 
> It clips for AutocompleteTextFieldEditor, we just need to shift the textview
to
> the left.
> If doesn't work out for AutocompleteTextfieldCell. Perhaps I am missing
> something?

I made some tweaks to what you were doing in your other cl and almost have that
working. I was thinking this cl might be better (and I'm not sure how hard it is
to fix the remaining problem in my cl), but this cl has a couple issues, I
discovered. First, the insertion point is now 1pt to the right of where it
normally is, at least when you place it at the start of the URL.As a result the
insertion point is drawing on top of the first character, which makes things
feel cramped. Second, for some reason if I click in the omnibox to select the
URL and then press left-arrow to position the insertion point at the start of
the text, I can still see a sliver of selection color when the insertion point
flashes out. Apparently someone isn't erasing the full selection rect; I don't
know if it's a Retina issue. Anyways, I have to run to lunch but I afterwards I
want to see if I can fix the remaining problem with my cl.

[spqchan, 2016-12-08 21:23:15]

On 2016/12/08 20:14:25, shrike wrote:
> On 2016/12/08 18:25:46, spqchan wrote:
> > On 2016/12/08 17:01:39, shrike wrote:
> > > On 2016/12/08 03:51:02, spqchan wrote:
> > > > Thanks for the suggestion! It's definitely simpler and something that'll
> be
> > > > useful for the future.
> > > > Unfortunately, the omnibox drawing is a bit complex for that to be
> > applicable
> > > =/
> > > > Using cliprect will clip out the left edge of the omnibox, not the left
> > > padding
> > > > with the text
> > > 
> > > Have you narrowed down the method that is doing the unwanted drawing?
> > 
> > That's a good point. AFAIK, the method doing the unwanted drawing is
> > AutocompleteTextfieldCell's drawInteriorWithFrame and
> > AutocompleteTextFieldEditor's drawRect
> > Here's my attempt: https://codereview.chromium.org/2563713002/
> > 
> > It clips for AutocompleteTextFieldEditor, we just need to shift the textview
> to
> > the left.
> > If doesn't work out for AutocompleteTextfieldCell. Perhaps I am missing
> > something?
> 
> I made some tweaks to what you were doing in your other cl and almost have
that
> working. I was thinking this cl might be better (and I'm not sure how hard it
is
> to fix the remaining problem in my cl), but this cl has a couple issues, I
> discovered. First, the insertion point is now 1pt to the right of where it
> normally is, at least when you place it at the start of the URL.As a result
the
> insertion point is drawing on top of the first character, which makes things
> feel cramped. Second, for some reason if I click in the omnibox to select the
> URL and then press left-arrow to position the insertion point at the start of
> the text, I can still see a sliver of selection color when the insertion point
> flashes out. Apparently someone isn't erasing the full selection rect; I don't
> know if it's a Retina issue. Anyways, I have to run to lunch but I afterwards
I
> want to see if I can fix the remaining problem with my cl.

Sounds good, let me know how it goes! Would you like to take over the bug?
I think you have a better idea on how to fix it and already did a lot of
investigation, so it will make more sense for you to take over it.
Thanks!

[shrike, 2016-12-08 23:44:31]

On 2016/12/08 21:23:15, spqchan wrote:
> Sounds good, let me know how it goes! Would you like to take over the bug?
> I think you have a better idea on how to fix it and already did a lot of
> investigation, so it will make more sense for you to take over it.
> Thanks!

OK.