Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2560973002: Remove unnecessary chrome window property util functions. (Closed)

Created:
4 years ago by msw
Modified:
4 years ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary chrome window property util functions. aura::PropertyConverter makes these functions obsolete. BUG=663522 TEST=No [title/shelf] changes for settings, task manager, app panel windows. R=sky@chromium.org Committed: https://crrev.com/6337d443bf35c959350e8cacdfdaca2ed8af39f6 Cr-Commit-Position: refs/heads/master@{#437304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -93 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/settings_window_observer.cc View 2 chunks +2 lines, -5 lines 0 comments Download
D chrome/browser/ui/ash/property_util.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/ui/ash/property_util.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
msw
Hey Scott, please take a look; thanks!
4 years ago (2016-12-08 00:11:31 UTC) #4
sky
I believe these are still necessary. The reason for that is that chrome is still ...
4 years ago (2016-12-08 04:06:25 UTC) #8
msw
On 2016/12/08 04:06:25, sky wrote: > I believe these are still necessary. The reason for ...
4 years ago (2016-12-08 18:50:49 UTC) #9
sky
None of this is critical, so you're right, it should be fine to change now. ...
4 years ago (2016-12-08 18:59:53 UTC) #10
msw
On 2016/12/08 18:59:53, sky wrote: > None of this is critical, so you're right, it ...
4 years ago (2016-12-08 19:11:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560973002/1
4 years ago (2016-12-08 19:12:35 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 19:23:59 UTC) #16
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6337d443bf35c959350e8cacdfdaca2ed8af39f6 Cr-Commit-Position: refs/heads/master@{#437304}
4 years ago (2016-12-08 19:26:07 UTC) #18
sky
Can you file bugs on panels and task manager shelf items please? On Thu, Dec ...
4 years ago (2016-12-08 20:20:07 UTC) #19
msw
On 2016/12/08 20:20:07, sky wrote: > Can you file bugs on panels and task manager ...
4 years ago (2016-12-08 20:43:52 UTC) #20
sky
4 years ago (2016-12-08 20:53:23 UTC) #21
Message was sent while issue was closed.
Thanks!

On Thu, Dec 8, 2016 at 12:43 PM,  <msw@chromium.org> wrote:
> On 2016/12/08 20:20:07, sky wrote:
>> Can you file bugs on panels and task manager shelf items please?
>
> Sure, I filed:
> mash: Shelf items outlive their windows crbug.com/672597
> mash: Shelf items for panel windows aren't right-aligned crbug.com/672599
>
> https://codereview.chromium.org/2560973002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698