Remove unnecessary chrome window property util functions.

Remove unnecessary chrome window property util functions.

aura::PropertyConverter makes these functions obsolete.

BUG=663522
TEST=No [title/shelf] changes for settings, task manager, app panel windows.
R=sky@chromium.org

Committed: https://crrev.com/6337d443bf35c959350e8cacdfdaca2ed8af39f6
Cr-Commit-Position: refs/heads/master@{#437304}

[msw, 2016-12-08 00:11:12]

Description was changed from

==========
Remove unnecessary chrome window property util functions.

BUG=663522
TEST
==========

to

==========
Remove unnecessary chrome window property util functions.

aura::PropertyConverter makes these functions obsolete.

BUG=663522
TEST=No [title/shelf] changes for settings, task manager, app panel windows.
R=sky@chromium.org
==========

[msw, 2016-12-08 00:11:12]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-12-08 00:11:18]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[msw, 2016-12-08 00:11:31]

Hey Scott, please take a look; thanks!

[commit-bot: I haz the power, 2016-12-08 00:11:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 01:07:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 01:07:47]

Dry run: This issue passed the CQ dry run.

[sky, 2016-12-08 04:06:25]

I believe these are still necessary. The reason for that is that chrome is still
using services/ui/public/cpp. Once we convert it to using aura-mus, then this
code can be nuked.

[msw, 2016-12-08 18:50:49]

On 2016/12/08 04:06:25, sky wrote:
> I believe these are still necessary. The reason for that is that chrome is
still
> using services/ui/public/cpp. Once we convert it to using aura-mus, then this
> code can be nuked.

You're concerned about chrome --mash regressing temporarily?
afaict, nothing actually regresses... but things overall are pretty broken.
Anything broken here would be fixed imminently with aura-mus, right?

[sky, 2016-12-08 18:59:53]

None of this is critical, so you're right, it should be fine to change now. LGTM

As to broken, I'm only aware of z-order painting issues, are there other things?

[msw, 2016-12-08 19:11:55]

On 2016/12/08 18:59:53, sky wrote:
> None of this is critical, so you're right, it should be fine to change now.
LGTM
> 
> As to broken, I'm only aware of z-order painting issues, are there other
things?

The chrome menu didn't appear for me in one run, perhaps bad z-ordering.
Panel windows aren't treated correctly in --mash, regardless of this CL.
Task manager shelf items stay beyond window life, also regardless of this CL.

[msw, 2016-12-08 19:12:02]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-12-08 19:12:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 19:23:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481224322899880, "parent_rev":
"ec477e593279da15cc1248b1dfad6ddfd9557320", "commit_rev":
"cabb25d1376ab88440f756d19dfcd92efa2e5e91"}

[commit-bot: I haz the power, 2016-12-08 19:23:58]

Description was changed from

==========
Remove unnecessary chrome window property util functions.

aura::PropertyConverter makes these functions obsolete.

BUG=663522
TEST=No [title/shelf] changes for settings, task manager, app panel windows.
R=sky@chromium.org
==========

to

==========
Remove unnecessary chrome window property util functions.

aura::PropertyConverter makes these functions obsolete.

BUG=663522
TEST=No [title/shelf] changes for settings, task manager, app panel windows.
R=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-12-08 19:23:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-08 19:26:06]

Description was changed from

==========
Remove unnecessary chrome window property util functions.

aura::PropertyConverter makes these functions obsolete.

BUG=663522
TEST=No [title/shelf] changes for settings, task manager, app panel windows.
R=sky@chromium.org
==========

to

==========
Remove unnecessary chrome window property util functions.

aura::PropertyConverter makes these functions obsolete.

BUG=663522
TEST=No [title/shelf] changes for settings, task manager, app panel windows.
R=sky@chromium.org

Committed: https://crrev.com/6337d443bf35c959350e8cacdfdaca2ed8af39f6
Cr-Commit-Position: refs/heads/master@{#437304}
==========

[commit-bot: I haz the power, 2016-12-08 19:26:07]

Patchset 1 (id:??) landed as
https://crrev.com/6337d443bf35c959350e8cacdfdaca2ed8af39f6
Cr-Commit-Position: refs/heads/master@{#437304}

[sky, 2016-12-08 20:20:07]

Can you file bugs on panels and task manager shelf items please?

On Thu, Dec 8, 2016 at 11:11 AM,  <msw@chromium.org> wrote:
> On 2016/12/08 18:59:53, sky wrote:
>> None of this is critical, so you're right, it should be fine to change
>> now.
> LGTM
>>
>> As to broken, I'm only aware of z-order painting issues, are there other
> things?
>
> The chrome menu didn't appear for me in one run, perhaps bad z-ordering.
> Panel windows aren't treated correctly in --mash, regardless of this CL.
> Task manager shelf items stay beyond window life, also regardless of this
> CL.
>
> https://codereview.chromium.org/2560973002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[msw, 2016-12-08 20:43:52]

On 2016/12/08 20:20:07, sky wrote:
> Can you file bugs on panels and task manager shelf items please?

Sure, I filed:
mash: Shelf items outlive their windows crbug.com/672597 
mash: Shelf items for panel windows aren't right-aligned crbug.com/672599

[sky, 2016-12-08 20:53:23]

Thanks!

On Thu, Dec 8, 2016 at 12:43 PM,  <msw@chromium.org> wrote:
> On 2016/12/08 20:20:07, sky wrote:
>> Can you file bugs on panels and task manager shelf items please?
>
> Sure, I filed:
> mash: Shelf items outlive their windows crbug.com/672597
> mash: Shelf items for panel windows aren't right-aligned crbug.com/672599
>
> https://codereview.chromium.org/2560973002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.