Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2560963002: [Devtools] Upgrade acorn services to use ECMAScript7 (Closed)

Created:
4 years ago by allada
Modified:
4 years ago
Reviewers:
lushnikov, PhistucK
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Upgrade acorn services to use ECMAScript7 Allows acorn to use ECMAScript7 for things like prettyprint. R=lushnikov BUG=667894 Committed: https://crrev.com/818678e082ef6f4de7dd31eacc0b2502d7263682 Cr-Commit-Position: refs/heads/master@{#437152}

Patch Set 1 #

Total comments: 1

Messages

Total messages: 10 (4 generated)
allada
PTL
4 years ago (2016-12-08 00:06:47 UTC) #1
lushnikov
lgtm!
4 years ago (2016-12-08 00:21:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560963002/1
4 years ago (2016-12-08 00:21:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 02:22:29 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/818678e082ef6f4de7dd31eacc0b2502d7263682 Cr-Commit-Position: refs/heads/master@{#437152}
4 years ago (2016-12-08 02:25:34 UTC) #8
PhistucK
4 years ago (2016-12-08 08:28:56 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/2560963002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/formatter_worker/AcornTokenizer.js
(right):

https://codereview.chromium.org/2560963002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/formatter_worker/AcornTokenizer.js:14:
this._tokenizer = acorn.tokenizer(this._content, {ecmaVersion: 7, onComment:
this._comments});
Maybe use a constant instead of using the same hard coded ecmaVersion number
everywhere?

Powered by Google App Engine
This is Rietveld 408576698