Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2560943002: [Devtools] Fixed dark theme scrollbars consistency in settings (Closed)

Created:
4 years ago by allada
Modified:
4 years ago
Reviewers:
dgozman, lushnikov, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixed dark theme scrollbars consistency in settings This patch fixes dark theme consistency in areas like settings. See: http://imgur.com/a/Bvb5n R=dgozman,lushnikov,pfeldman BUG=587780 Committed: https://crrev.com/a536a7769a1652139bd69b6cf58866e5fc9e7fbc Cr-Commit-Position: refs/heads/master@{#437180}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -26 lines) Patch
M third_party/WebKit/Source/devtools/front_end/settings/settingsScreen.css View 1 chunk +0 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
allada
PTL
4 years ago (2016-12-07 22:46:37 UTC) #1
dgozman
lgtm
4 years ago (2016-12-08 00:12:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560943002/1
4 years ago (2016-12-08 00:18:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/81711)
4 years ago (2016-12-08 01:33:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560943002/1
4 years ago (2016-12-08 01:43:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/81844)
4 years ago (2016-12-08 03:21:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560943002/1
4 years ago (2016-12-08 03:22:34 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 04:35:24 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-08 04:38:01 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a536a7769a1652139bd69b6cf58866e5fc9e7fbc
Cr-Commit-Position: refs/heads/master@{#437180}

Powered by Google App Engine
This is Rietveld 408576698