|
|
DescriptionDon't run the prerendering tests that verify prerendering is cancelled for cross-process navigations under PlzNavigate.
Prerendering has these tests since it requires only one render process is used for prerendering. Without PlzNavigate, it detects a cross-process navigation and cancels prerendering. However with PlzNavigate, this scenario doesn't exist since we only determine the (one) render process to use for prerendering after redirects have been followed.
This fixes
PrerenderBrowserTest.PrerenderCrossProcessServerRedirect
PrerenderBrowserTest.PrerenderCrossProcessServerRedirectNoHang
with PlzNavigate.
BUG=504347
Committed: https://crrev.com/bd44869fbaac11ae098a76ac90d6a9037664c28f
Cr-Commit-Position: refs/heads/master@{#437490}
Patch Set 1 #Patch Set 2 : merge #Patch Set 3 : merge #
Messages
Total messages: 36 (25 generated)
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Don't run the prerendering tests that verify prerendering is cancelled for cross-process navigations under PlzNavigate. Prerendering has these tests since it assumes only one render process is used for prerendering. Without PlzNavigate, it detects a cross-process navigation and cancells prerendering. However with PlzNavigate, this scenario doesn't exist since we only determine the (one) render process to use for prerendering after redirects have been followed. This fixes PrerenderBrowserTest.PrerenderCrossProcessServerRedirect PrerenderBrowserTest.PrerenderCrossProcessServerRedirectNoHang with PlzNavigate. BUG=504347 ========== to ========== Don't run the prerendering tests that verify prerendering is cancelled for cross-process navigations under PlzNavigate. Prerendering has these tests since it requires only one render process is used for prerendering. Without PlzNavigate, it detects a cross-process navigation and cancels prerendering. However with PlzNavigate, this scenario doesn't exist since we only determine the (one) render process to use for prerendering after redirects have been followed. This fixes PrerenderBrowserTest.PrerenderCrossProcessServerRedirect PrerenderBrowserTest.PrerenderCrossProcessServerRedirectNoHang with PlzNavigate. BUG=504347 ==========
jam@chromium.org changed reviewers: + nasko@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter: While running git apply --index -p1; error: patch failed: testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter:3 error: testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter: patch does not apply Patch: testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter Index: testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter diff --git a/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter b/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter index 998192dc4f274358cfd3fd3d947c375be92a4005..e9e8336c80d5a5c281259249cb131490b7885e38 100644 --- a/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter +++ b/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter @@ -3,8 +3,6 @@ -PlatformAppBrowserTest.ActiveAppsAreRecorded -PlatformAppUrlRedirectorBrowserTest.PrerenderedClickInTabIntercepted -PredictorBrowserTest.RendererInitiatedNavigationPreconnect --PrerenderBrowserTest.PrerenderCrossProcessServerRedirect --PrerenderBrowserTest.PrerenderCrossProcessServerRedirectNoHang # TabManagerTest.TabManagerBasics crashes sometimes -TabManagerTest.TabManagerBasics -ThreatDOMDetailsTest.Everything
The CQ bit was checked by jam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org Link to the patchset: https://codereview.chromium.org/2560933002/#ps40001 (title: "merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org Link to the patchset: https://codereview.chromium.org/2560933002/#ps60001 (title: "merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481264978971360, "parent_rev": "58834b660c79b9a28937cd17d511494667f0d843", "commit_rev": "1ecade0db61e3122b667c92b90974ceb60ceb37a"}
Message was sent while issue was closed.
Description was changed from ========== Don't run the prerendering tests that verify prerendering is cancelled for cross-process navigations under PlzNavigate. Prerendering has these tests since it requires only one render process is used for prerendering. Without PlzNavigate, it detects a cross-process navigation and cancels prerendering. However with PlzNavigate, this scenario doesn't exist since we only determine the (one) render process to use for prerendering after redirects have been followed. This fixes PrerenderBrowserTest.PrerenderCrossProcessServerRedirect PrerenderBrowserTest.PrerenderCrossProcessServerRedirectNoHang with PlzNavigate. BUG=504347 ========== to ========== Don't run the prerendering tests that verify prerendering is cancelled for cross-process navigations under PlzNavigate. Prerendering has these tests since it requires only one render process is used for prerendering. Without PlzNavigate, it detects a cross-process navigation and cancels prerendering. However with PlzNavigate, this scenario doesn't exist since we only determine the (one) render process to use for prerendering after redirects have been followed. This fixes PrerenderBrowserTest.PrerenderCrossProcessServerRedirect PrerenderBrowserTest.PrerenderCrossProcessServerRedirectNoHang with PlzNavigate. BUG=504347 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Don't run the prerendering tests that verify prerendering is cancelled for cross-process navigations under PlzNavigate. Prerendering has these tests since it requires only one render process is used for prerendering. Without PlzNavigate, it detects a cross-process navigation and cancels prerendering. However with PlzNavigate, this scenario doesn't exist since we only determine the (one) render process to use for prerendering after redirects have been followed. This fixes PrerenderBrowserTest.PrerenderCrossProcessServerRedirect PrerenderBrowserTest.PrerenderCrossProcessServerRedirectNoHang with PlzNavigate. BUG=504347 ========== to ========== Don't run the prerendering tests that verify prerendering is cancelled for cross-process navigations under PlzNavigate. Prerendering has these tests since it requires only one render process is used for prerendering. Without PlzNavigate, it detects a cross-process navigation and cancels prerendering. However with PlzNavigate, this scenario doesn't exist since we only determine the (one) render process to use for prerendering after redirects have been followed. This fixes PrerenderBrowserTest.PrerenderCrossProcessServerRedirect PrerenderBrowserTest.PrerenderCrossProcessServerRedirectNoHang with PlzNavigate. BUG=504347 Committed: https://crrev.com/bd44869fbaac11ae098a76ac90d6a9037664c28f Cr-Commit-Position: refs/heads/master@{#437490} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/bd44869fbaac11ae098a76ac90d6a9037664c28f Cr-Commit-Position: refs/heads/master@{#437490} |