Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2560933002: Don't run the prerendering tests that verify prerendering is cancelled for cross-process navigation… (Closed)

Created:
4 years ago by jam
Modified:
4 years ago
Reviewers:
nasko
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't run the prerendering tests that verify prerendering is cancelled for cross-process navigations under PlzNavigate. Prerendering has these tests since it requires only one render process is used for prerendering. Without PlzNavigate, it detects a cross-process navigation and cancels prerendering. However with PlzNavigate, this scenario doesn't exist since we only determine the (one) render process to use for prerendering after redirects have been followed. This fixes PrerenderBrowserTest.PrerenderCrossProcessServerRedirect PrerenderBrowserTest.PrerenderCrossProcessServerRedirectNoHang with PlzNavigate. BUG=504347 Committed: https://crrev.com/bd44869fbaac11ae098a76ac90d6a9037664c28f Cr-Commit-Position: refs/heads/master@{#437490}

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 1 3 chunks +11 lines, -0 lines 0 comments Download
M testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 36 (25 generated)
jam
4 years ago (2016-12-07 20:29:20 UTC) #8
nasko
LGTM
4 years ago (2016-12-08 21:51:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560933002/20001
4 years ago (2016-12-08 22:05:07 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/352910)
4 years ago (2016-12-09 00:17:05 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560933002/20001
4 years ago (2016-12-09 01:07:03 UTC) #21
commit-bot: I haz the power
Failed to apply patch for testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter: While running git apply --index -p1; error: patch failed: ...
4 years ago (2016-12-09 02:30:22 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560933002/40001
4 years ago (2016-12-09 02:41:42 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/285771)
4 years ago (2016-12-09 02:44:10 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560933002/60001
4 years ago (2016-12-09 06:29:57 UTC) #31
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years ago (2016-12-09 07:36:13 UTC) #34
commit-bot: I haz the power
4 years ago (2016-12-09 07:38:10 UTC) #36
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bd44869fbaac11ae098a76ac90d6a9037664c28f
Cr-Commit-Position: refs/heads/master@{#437490}

Powered by Google App Engine
This is Rietveld 408576698