Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2560893002: [interpreter] Avoid code duplication in Interpreter::Initialize(). (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Avoid code duplication in Interpreter::Initialize(). BUG= Committed: https://crrev.com/0d2925054772dfbb393c0971bf425909679ea4ef Cr-Commit-Position: refs/heads/master@{#41561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -24 lines) Patch
M src/interpreter/interpreter.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 2 chunks +24 lines, -24 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-07 18:33:11 UTC) #4
rmcilroy
LGTM, thanks.
4 years ago (2016-12-07 18:42:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560893002/1
4 years ago (2016-12-07 18:43:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 18:53:18 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-07 18:53:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d2925054772dfbb393c0971bf425909679ea4ef
Cr-Commit-Position: refs/heads/master@{#41561}

Powered by Google App Engine
This is Rietveld 408576698