Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: net/quic/core/quic_sent_packet_manager_test.cc

Issue 2560873003: Deprecate FLAGS_quic_default_enable_cubic_bytes (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_sent_packet_manager.cc ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_sent_packet_manager_test.cc
diff --git a/net/quic/core/quic_sent_packet_manager_test.cc b/net/quic/core/quic_sent_packet_manager_test.cc
index 4cc638b3d3c7aa7a430d2deddb1c511d396d2a25..bc6d0e1d1a4542b7ccd0259fc4883c30ffc1d441 100644
--- a/net/quic/core/quic_sent_packet_manager_test.cc
+++ b/net/quic/core/quic_sent_packet_manager_test.cc
@@ -62,7 +62,7 @@ class QuicSentPacketManagerTest : public ::testing::Test {
kDefaultPathId,
&clock_,
&stats_,
- FLAGS_quic_default_enable_cubic_bytes ? kCubicBytes : kCubic,
+ kCubicBytes,
kNack,
/*delegate=*/nullptr),
send_algorithm_(new StrictMock<MockSendAlgorithm>),
@@ -1412,13 +1412,8 @@ TEST_F(QuicSentPacketManagerTest, NegotiateCongestionControlFromOptions) {
QuicConfigPeer::SetReceivedConnectionOptions(&config, options);
EXPECT_CALL(*network_change_visitor_, OnCongestionChange());
manager_.SetFromConfig(config);
- if (FLAGS_quic_default_enable_cubic_bytes) {
- EXPECT_EQ(kCubic, QuicSentPacketManagerPeer::GetSendAlgorithm(manager_)
- ->GetCongestionControlType());
- } else {
- EXPECT_EQ(kCubicBytes, QuicSentPacketManagerPeer::GetSendAlgorithm(manager_)
- ->GetCongestionControlType());
- }
+ EXPECT_EQ(kCubic, QuicSentPacketManagerPeer::GetSendAlgorithm(manager_)
+ ->GetCongestionControlType());
options.clear();
options.push_back(kRENO);
@@ -1466,13 +1461,8 @@ TEST_F(QuicSentPacketManagerTest, NegotiateClientCongestionControlFromOptions) {
config.SetClientConnectionOptions(options);
EXPECT_CALL(*network_change_visitor_, OnCongestionChange());
manager_.SetFromConfig(config);
- if (FLAGS_quic_default_enable_cubic_bytes) {
- EXPECT_EQ(kCubic, QuicSentPacketManagerPeer::GetSendAlgorithm(manager_)
- ->GetCongestionControlType());
- } else {
- EXPECT_EQ(kCubicBytes, QuicSentPacketManagerPeer::GetSendAlgorithm(manager_)
- ->GetCongestionControlType());
- }
+ EXPECT_EQ(kCubic, QuicSentPacketManagerPeer::GetSendAlgorithm(manager_)
+ ->GetCongestionControlType());
options.clear();
options.push_back(kRENO);
« no previous file with comments | « net/quic/core/quic_sent_packet_manager.cc ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698