Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2560863002: Disable HttpsEngagementMetricsProvider (Closed)

Created:
4 years ago by Bryan McQuade
Modified:
4 years ago
Reviewers:
Ilya Sherman
CC:
asvitkine+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable HttpsEngagementMetricsProvider HttpsEngagementMetricsProvider looks up the most recent profile in its ProvideGeneralMetrics callback. This is causing a crash in Linux M55 stable. To address this in the near term, we simply disable the HttpsEngagementMetricsProvider for the time being. BUG=671579 Committed: https://crrev.com/2e483c00b3fa6596b58ffa1a39cd692f485de76e Cr-Commit-Position: refs/heads/master@{#437043}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/browser/metrics/chrome_metrics_service_client.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Bryan McQuade
isherman, PTAL
4 years ago (2016-12-07 17:16:41 UTC) #5
Ilya Sherman
LGTM, thanks.
4 years ago (2016-12-07 19:38:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560863002/1
4 years ago (2016-12-07 20:05:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 20:11:38 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-07 20:14:02 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e483c00b3fa6596b58ffa1a39cd692f485de76e
Cr-Commit-Position: refs/heads/master@{#437043}

Powered by Google App Engine
This is Rietveld 408576698