chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java - Issue 2560843003: Don't try to enter VR onResume for Cardboard mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2560843003: Don't try to enter VR onResume for Cardboard mode (Closed)

Patch Set: nits Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

index 8c7e1c3942bf85a8762dd535975c32b8ce5159b8..853aabd8411d896adcd01ff83ae3469516eccb16 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

@@ -1236,7 +1236,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode

if (!mUIInitialized) return false;

final Tab currentTab = getActivityTab();

- if (mVrShellDelegate.exitVRIfNecessary(true)) return true;

+ if (mVrShellDelegate.exitVRIfNecessary(false /* isPausing */)) return true;

if (currentTab == null) {

recordBackPressedUma("currentTab is null", BACK_PRESSED_TAB_IS_NULL);

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java » ('j') | no next file with comments »