Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 256083003: Move bookmark_model_observer.h to the bookmarks component (Closed)

Created:
6 years, 7 months ago by sdefresne
Modified:
6 years, 7 months ago
Reviewers:
sky, blundell
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, tfarina, dbeam+watch-ntp_chromium.org, haitaol+watch_chromium.org, browser-components-watch_chromium.org, estade+watch_chromium.org, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move bookmark_model_observer.h to the bookmarks component Move bookmark_model_observer.h and base_bookmark_model_observer.{cc,h} from chrome/browser/bookmarks to components/bookmarks as they do not depend on anything in chrome/browser. BUG=367656 TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266563

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -261 lines) Patch
M chrome/browser/android/bookmarks/bookmarks_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/provider/bookmark_model_observer_task.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/bookmarks/base_bookmark_model_observer.h View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/bookmarks/base_bookmark_model_observer.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_expanded_state_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_model.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/bookmarks/bookmark_model_observer.h View 1 chunk +0 lines, -115 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_test_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_utils_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/external_process_importer_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/bookmark_model_loaded_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/recently_used_folders_combo_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/wrench_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/android/bookmarks_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/undo/bookmark_undo_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M components/bookmarks.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
A + components/bookmarks/core/browser/base_bookmark_model_observer.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/bookmarks/core/browser/base_bookmark_model_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/bookmarks/core/browser/bookmark_model_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sdefresne
PTAL
6 years, 7 months ago (2014-04-28 10:45:39 UTC) #1
blundell
lgtm
6 years, 7 months ago (2014-04-28 11:24:05 UTC) #2
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 7 months ago (2014-04-28 11:27:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/256083003/1
6 years, 7 months ago (2014-04-28 11:27:55 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 14:40:35 UTC) #5
Message was sent while issue was closed. 
Change committed as 266563

Powered by Google App Engine
This is Rietveld 408576698