src/heap/heap.cc - Issue 2560813002: [heap] Do not delay mark-compact in Heap::CollectGarbage if incremental

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 2560813002: [heap] Do not delay mark-compact in Heap::CollectGarbage if incremental (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index 6612840504b94645dcc4663d746bdcdf3ca2f683..8d20cadd0b00f0eebddd1874b7601f5a2b5b7f2f 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -962,6 +962,7 @@ bool Heap::CollectGarbage(GarbageCollector collector,

!ShouldFinalizeIncrementalMarking() && !ShouldAbortIncrementalMarking() &&

!incremental_marking()->IsStopped() &&

!incremental_marking()->should_hurry() &&

+ !incremental_marking()->NeedsFinalization() &&

!IsCloseToOutOfMemory(new_space_->Capacity())) {

if (!incremental_marking()->IsComplete() &&

!mark_compact_collector()->marking_deque()->IsEmpty() &&

« no previous file with comments | « no previous file | no next file » | no next file with comments »