Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1925)

Unified Diff: ash/common/system/chromeos/ime_menu/ime_list_view.h

Issue 2560793002: Request focus on IME menu rows after keyboard selection (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/chromeos/ime_menu/ime_list_view.h
diff --git a/ash/common/system/chromeos/ime_menu/ime_list_view.h b/ash/common/system/chromeos/ime_menu/ime_list_view.h
index 745a8348f7669234562d312b1d7ccd2c26b8bc17..60a5ccc9ac5d7ee526eb26aa601a4ef35f2f8ad3 100644
--- a/ash/common/system/chromeos/ime_menu/ime_list_view.h
+++ b/ash/common/system/chromeos/ime_menu/ime_list_view.h
@@ -28,6 +28,9 @@ class ImeListView : public TrayDetailsView {
~ImeListView() override;
+ // Focuses to the current IME if the IME is selected with keyboard.
tdanderson 2016/12/08 00:42:11 I think you can make this private. Also it would b
Azure Wei 2016/12/08 13:14:55 Done.
+ void FocusCurrentImeIfNeeded();
+
// Updates the view.
virtual void Update(const IMEInfoList& list,
const IMEPropertyInfoList& property_list,
@@ -37,6 +40,9 @@ class ImeListView : public TrayDetailsView {
// Removes (and destroys) all child views.
virtual void ResetImeListView();
+ // Handles the event that a view has been pressed.
+ void HandleViewPressed(views::View* view);
tdanderson 2016/12/08 00:42:11 I think this can be made private. And to avoid con
Azure Wei 2016/12/08 13:14:55 This is declared public since it's called by ImeLi
tdanderson 2016/12/08 22:56:37 Acknowledged.
+
// TrayDetailsView:
void HandleViewClicked(views::View* view) override;
void HandleButtonPressed(views::Button* sender,
@@ -70,6 +76,7 @@ class ImeListView : public TrayDetailsView {
views::View* keyboard_status_;
// On-screen keyboard view which is only used in material design.
MaterialKeyboardStatusRowView* material_keyboard_status_view_;
+ std::string last_pressed_item_id_;
DISALLOW_COPY_AND_ASSIGN(ImeListView);
};

Powered by Google App Engine
This is Rietveld 408576698