components/ntp_snippets/content_suggestions_service.h - Issue 2560783002: [NTP::PhysicalWeb] Implement suggestion dismissal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/content_suggestions_service.h

Issue 2560783002: [NTP::PhysicalWeb] Implement suggestion dismissal. (Closed)

Patch Set: rebase and bauerb@ nit. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_snippets/content_suggestions_service.h

diff --git a/components/ntp_snippets/content_suggestions_service.h b/components/ntp_snippets/content_suggestions_service.h

index 2ada1db494561ff727a374eb24201f7eaaee26c2..f8a96a69e416f5bef9d5bc343fa20e156febe01b 100644

--- a/components/ntp_snippets/content_suggestions_service.h

+++ b/components/ntp_snippets/content_suggestions_service.h

@@ -122,7 +122,8 @@ class ContentSuggestionsService : public KeyedService,

const ImageFetchedCallback& callback);

// Dismisses the suggestion with the given |suggestion_id|, if it exists.

- // This will not trigger an update through the observers.

+ // This will not trigger an update through the observers (i.e. providers must

+ // not call |Observer::OnNewSuggestions|).

void DismissSuggestion(const ContentSuggestion::ID& suggestion_id);

// Dismisses the given |category|, if it exists.