chrome/browser/android/preferences/browser_prefs_android.cc - Issue 2560783002: [NTP::PhysicalWeb] Implement suggestion dismissal.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/android/preferences/browser_prefs_android.cc

Issue 2560783002: [NTP::PhysicalWeb] Implement suggestion dismissal. (Closed)

Patch Set: rebase and jkrcal@ comment. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/ntp_snippets/content_suggestions_service_factory.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/android/preferences/browser_prefs_android.h"	5 #include "chrome/browser/android/preferences/browser_prefs_android.h"

6	6

7 #include "blimp/client/public/blimp_client_context.h"	7 #include "blimp/client/public/blimp_client_context.h"

8 #include "chrome/browser/android/search_geolocation_disclosure_tab_helper.h"	8 #include "chrome/browser/android/search_geolocation_disclosure_tab_helper.h"

9 #include "chrome/browser/notifications/notification_platform_bridge_android.h"	9 #include "chrome/browser/notifications/notification_platform_bridge_android.h"

10 #include "chrome/browser/ntp_snippets/download_suggestions_provider.h"	10 #include "chrome/browser/ntp_snippets/download_suggestions_provider.h"

11 #include "components/ntp_snippets/offline_pages/recent_tab_suggestions_provider. h"	11 #include "components/ntp_snippets/offline_pages/recent_tab_suggestions_provider. h"

	12 #include "components/ntp_snippets/physical_web_pages/physical_web_page_suggestio ns_provider.h"

12 #include "components/pref_registry/pref_registry_syncable.h"	13 #include "components/pref_registry/pref_registry_syncable.h"

13 #include "components/prefs/pref_registry_simple.h"	14 #include "components/prefs/pref_registry_simple.h"

14	15

15 namespace android {	16 namespace android {

16	17

17 void RegisterUserProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {	18 void RegisterUserProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {

18 DownloadSuggestionsProvider::RegisterProfilePrefs(registry);	19 DownloadSuggestionsProvider::RegisterProfilePrefs(registry);

19 NotificationPlatformBridgeAndroid::RegisterProfilePrefs(registry);	20 NotificationPlatformBridgeAndroid::RegisterProfilePrefs(registry);

20 SearchGeolocationDisclosureTabHelper::RegisterProfilePrefs(registry);	21 SearchGeolocationDisclosureTabHelper::RegisterProfilePrefs(registry);

	22 ntp_snippets::PhysicalWebPageSuggestionsProvider::RegisterProfilePrefs(

	23 registry);

21 ntp_snippets::RecentTabSuggestionsProvider::RegisterProfilePrefs(registry);	24 ntp_snippets::RecentTabSuggestionsProvider::RegisterProfilePrefs(registry);
	Bernhard Bauer 2016/12/08 15:09:39 In retrospect, it would probably make more sense t In retrospect, it would probably make more sense to register NTP snippets prefs directly in browser_prefs (just inside an #ifdef) instead of here. vitaliii 2016/12/09 09:20:31 Done. Show quoted text On 2016/12/08 15:09:39, Bernhard Bauer wrote: > In retrospect, it would probably make more sense to register NTP snippets prefs > directly in browser_prefs (just inside an #ifdef) instead of here. Done.
22 blimp::client::BlimpClientContext::RegisterPrefs(registry);	25 blimp::client::BlimpClientContext::RegisterPrefs(registry);

23 }	26 }

24	27

25 } // namespace android	28 } // namespace android

OLD	NEW