Don't allow <use> <text> references in clip-path fast-path

Don't allow <use> <text> references in clip-path fast-path

The fast-path can't handle <text>, but a <use> referencing <text> was
not properly checked resulting in an incorrect clip.
Make the requiresMask(...) helper handle <use> elements and check the
referenced element.

BUG=604677, 604679
Committed: https://crrev.com/e139f0e0cd2bcb12d398d05a3ddaf32de010477b
Cr-Commit-Position: refs/heads/master@{#436941}

[fs, 2016-12-07 12:21:46]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 12:22:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-12-07 13:40:41]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, schenney@chromium.org

[f(malita), 2016-12-07 13:58:09]

LGTM

https://codereview.chromium.org/2560773002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp
(right):

https://codereview.chromium.org/2560773002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp:48: bool
requiresMask(const SVGElement& element) {
There seems to be some overlap between contributesToClip() and requiresMask(). 
Maybe in the future we could merge them into something that returns a ternary
enum (determineClipHandling -> none/mask/path)?

[commit-bot: I haz the power, 2016-12-07 14:05:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 14:05:20]

Dry run: This issue passed the CQ dry run.

[fs, 2016-12-07 14:11:43]

https://codereview.chromium.org/2560773002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp
(right):

https://codereview.chromium.org/2560773002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp:48: bool
requiresMask(const SVGElement& element) {
On 2016/12/07 at 13:58:09, f(malita) wrote:
> There seems to be some overlap between contributesToClip() and requiresMask().
 Maybe in the future we could merge them into something that returns a ternary
enum (determineClipHandling -> none/mask/path)?

Yes, that sounds like it might work. Will look into it when I get the time.

[fs, 2016-12-07 14:11:54]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-12-07 14:12:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 14:16:12]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481119914253720, "parent_rev":
"8449496869a607aa7088d4a7d72e1be35220318f", "commit_rev":
"299a6ef1f80429302534a6611dd51399e26dfbde"}

[commit-bot: I haz the power, 2016-12-07 14:16:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-07 14:19:52]

Description was changed from

==========
Don't allow <use> <text> references in clip-path fast-path

The fast-path can't handle <text>, but a <use> referencing <text> was
not properly checked resulting in an incorrect clip.
Make the requiresMask(...) helper handle <use> elements and check the
referenced element.

BUG=604677,604679
==========

to

==========
Don't allow <use> <text> references in clip-path fast-path

The fast-path can't handle <text>, but a <use> referencing <text> was
not properly checked resulting in an incorrect clip.
Make the requiresMask(...) helper handle <use> elements and check the
referenced element.

BUG=604677,604679

Committed: https://crrev.com/e139f0e0cd2bcb12d398d05a3ddaf32de010477b
Cr-Commit-Position: refs/heads/master@{#436941}
==========

[commit-bot: I haz the power, 2016-12-07 14:19:53]

Patchset 1 (id:??) landed as
https://crrev.com/e139f0e0cd2bcb12d398d05a3ddaf32de010477b
Cr-Commit-Position: refs/heads/master@{#436941}