Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2560773002: Don't allow <use> <text> references in clip-path fast-path (Closed)

Created:
4 years ago by fs
Modified:
4 years ago
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't allow <use> <text> references in clip-path fast-path The fast-path can't handle <text>, but a <use> referencing <text> was not properly checked resulting in an incorrect clip. Make the requiresMask(...) helper handle <use> elements and check the referenced element. BUG=604677, 604679 Committed: https://crrev.com/e139f0e0cd2bcb12d398d05a3ddaf32de010477b Cr-Commit-Position: refs/heads/master@{#436941}

Patch Set 1 #

Total comments: 2

Messages

Total messages: 14 (8 generated)
fs
4 years ago (2016-12-07 13:40:42 UTC) #4
f(malita)
LGTM https://codereview.chromium.org/2560773002/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp File third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp (right): https://codereview.chromium.org/2560773002/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp#newcode48 third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp:48: bool requiresMask(const SVGElement& element) { There seems to ...
4 years ago (2016-12-07 13:58:09 UTC) #5
fs
https://codereview.chromium.org/2560773002/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp File third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp (right): https://codereview.chromium.org/2560773002/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp#newcode48 third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp:48: bool requiresMask(const SVGElement& element) { On 2016/12/07 at 13:58:09, ...
4 years ago (2016-12-07 14:11:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560773002/1
4 years ago (2016-12-07 14:12:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 14:16:43 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-07 14:19:53 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e139f0e0cd2bcb12d398d05a3ddaf32de010477b
Cr-Commit-Position: refs/heads/master@{#436941}

Powered by Google App Engine
This is Rietveld 408576698