Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 25607005: Fix WHITESPACE issues in the CSS grammar. (Closed)

Created:
7 years, 2 months ago by rune
Modified:
7 years, 2 months ago
Reviewers:
apavlov
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, chromiumbugtracker_adobe.com, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix WHITESPACE issues in the CSS grammar. A single WHITESPACE token consumes consecutive spaces, but does not consume spaces separated by comments. That means S* and S+ in CSS grammars need to accept multiple WHITESPACE tokens. Additionally, white spaces are not mandatory to separate an @-symbol and the rest of the prelude. Use space non-terminal instead of WHITESPACE for S+ in calc expressions. Use maybe_space non-terminal instead of WHITESPACE for S* after @-webkit-filter and @-webkit-region. BUG=303303 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158950

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -4 lines) Patch
M LayoutTests/css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid-expected.txt View 1 chunk +36 lines, -0 lines 0 comments Download
M LayoutTests/css3/filters/custom-with-at-rule-syntax/script-tests/parsing-at-rule-valid.js View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/calc-comments-allowed.html View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/calc-comments-allowed-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/webkit-region-syntax-space.html View 1 chunk +32 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/webkit-region-syntax-space-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/css/CSSGrammar.y.in View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rune
7 years, 2 months ago (2013-10-02 20:26:32 UTC) #1
apavlov
lgtm
7 years, 2 months ago (2013-10-04 13:49:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/25607005/1
7 years, 2 months ago (2013-10-04 13:49:45 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=8944
7 years, 2 months ago (2013-10-04 16:44:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/25607005/1
7 years, 2 months ago (2013-10-04 17:04:22 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-04 17:55:57 UTC) #6
Message was sent while issue was closed.
Change committed as 158950

Powered by Google App Engine
This is Rietveld 408576698