Disable form elements in MHTML

Disable form elements in MHTML

MHTML is loaded in full sandboxing mode and thus the form cannot
be submitted and the script execution is disabled. So we want to
disable all form elements in order to give a clear indication to
the user that the form cannot be worked on.

BUG=669325
TEST=new tests added

Committed: https://crrev.com/ea856e3748ce4836299faf081f96c0b37ee923b6
Cr-Commit-Position: refs/heads/master@{#437362}

[jianli, 2016-12-07 01:15:40]

Patchset #1 (id:1) has been deleted

[jianli, 2016-12-07 01:16:02]

The CQ bit was checked by jianli@chromium.org to run a CQ dry run

[jianli, 2016-12-07 01:16:33]

jianli@chromium.org changed reviewers:
+ carlosk@chromium.org, tkent@chromium.org

[commit-bot: I haz the power, 2016-12-07 01:16:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 02:50:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 02:50:16]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[carlosk, 2016-12-07 21:07:23]

https://codereview.chromium.org/2560693002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebFrameSerializer.cpp (right):

https://codereview.chromium.org/2560693002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebFrameSerializer.cpp:179: for (const auto&
attribute : element.attributes()) {
Using one of Element's own methods methods to do this work should simplify this
function: fastHasAttribute and hasAttribute. And I think the "fast" version is
applicable for the "disabled" attribute.

https://codereview.chromium.org/2560693002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/tests/data/frameserialization/form.html
(right):

https://codereview.chromium.org/2560693002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/tests/data/frameserialization/form.html:4: <form>
I'd suggest also adding a few input attributes that do already have the disabled
attribute to cover the logic of not adding it when it already exists.

[jianli, 2016-12-07 22:10:42]

The CQ bit was checked by jianli@chromium.org to run a CQ dry run

[jianli, 2016-12-07 22:10:48]

https://codereview.chromium.org/2560693002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebFrameSerializer.cpp (right):

https://codereview.chromium.org/2560693002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebFrameSerializer.cpp:179: for (const auto&
attribute : element.attributes()) {
On 2016/12/07 21:07:23, carlosk wrote:
> Using one of Element's own methods methods to do this work should simplify
this
> function: fastHasAttribute and hasAttribute. And I think the "fast" version is
> applicable for the "disabled" attribute.

Done.

https://codereview.chromium.org/2560693002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/tests/data/frameserialization/form.html
(right):

https://codereview.chromium.org/2560693002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/tests/data/frameserialization/form.html:4: <form>
On 2016/12/07 21:07:23, carlosk wrote:
> I'd suggest also adding a few input attributes that do already have the
disabled
> attribute to cover the logic of not adding it when it already exists.

Done.

[commit-bot: I haz the power, 2016-12-07 22:11:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 23:51:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 23:51:57]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[tkent, 2016-12-08 02:07:51]

lgtm

[jianli, 2016-12-08 02:24:21]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2016-12-08 02:24:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 03:50:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 03:50:33]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[jianli, 2016-12-08 21:35:03]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2016-12-08 21:35:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 22:11:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481232903233220,
"parent_rev": "da3b955eed0c86e66a7d483af4acdfc5e8aec32b", "commit_rev":
"4fd5cc6dc708bf1b05102a4429b2112f91f84fd7"}

[commit-bot: I haz the power, 2016-12-08 22:12:05]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-12-08 22:14:50]

Description was changed from

==========
Disable form elements in MHTML

MHTML is loaded in full sandboxing mode and thus the form cannot
be submitted and the script execution is disabled. So we want to
disable all form elements in order to give a clear indication to
the user that the form cannot be worked on.

BUG=669325
TEST=new tests added
==========

to

==========
Disable form elements in MHTML

MHTML is loaded in full sandboxing mode and thus the form cannot
be submitted and the script execution is disabled. So we want to
disable all form elements in order to give a clear indication to
the user that the form cannot be worked on.

BUG=669325
TEST=new tests added

Committed: https://crrev.com/ea856e3748ce4836299faf081f96c0b37ee923b6
Cr-Commit-Position: refs/heads/master@{#437362}
==========

[commit-bot: I haz the power, 2016-12-08 22:14:51]

Patchset 2 (id:??) landed as
https://crrev.com/ea856e3748ce4836299faf081f96c0b37ee923b6
Cr-Commit-Position: refs/heads/master@{#437362}