Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5926)

Unified Diff: chrome/browser/external_protocol_handler.cc

Issue 256065: External protocol dialog support for the Mac.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/external_protocol_handler.cc
===================================================================
--- chrome/browser/external_protocol_handler.cc (revision 28103)
+++ chrome/browser/external_protocol_handler.cc (working copy)
@@ -90,7 +90,7 @@
}
// Check the stored prefs.
- // TODO(pkasting): http://b/119651 This kind of thing should go in the
+ // TODO(pkasting): http://b/1119651 This kind of thing should go in the
// preferences on the profile, not in the local state.
PrefService* pref = g_browser_process->local_state();
if (pref) { // May be NULL during testing.
@@ -110,6 +110,25 @@
}
// static
+void ExternalProtocolHandler::SetBlockState(const std::wstring& scheme,
+ BlockState state) {
+ // Set in the stored prefs.
+ // TODO(pkasting): http://b/1119651 This kind of thing should go in the
+ // preferences on the profile, not in the local state.
+ PrefService* pref = g_browser_process->local_state();
+ if (pref) { // May be NULL during testing.
+ DictionaryValue* win_pref =
+ pref->GetMutableDictionary(prefs::kExcludedSchemes);
+ CHECK(win_pref);
+
+ if (state == UNKNOWN)
+ win_pref->Remove(scheme, NULL);
+ else
+ win_pref->SetBoolean(scheme, state == BLOCK ? true : false);
+ }
+}
+
+// static
void ExternalProtocolHandler::LaunchUrl(const GURL& url,
int render_process_host_id,
int tab_contents_id) {
@@ -124,7 +143,7 @@
return;
if (block_state == UNKNOWN) {
-#if defined(OS_WIN) || defined(TOOLKIT_GTK)
+#if defined(OS_WIN) || defined(TOOLKIT_GTK) || defined(OS_MACOSX)
g_accept_requests = false;
// Ask the user if they want to allow the protocol. This will call
// LaunchUrlWithoutSecurityCheck if the user decides to accept the protocol.
@@ -132,8 +151,8 @@
render_process_host_id,
tab_contents_id);
#endif
- // For now, allow only whitelisted protocols to fire on Mac and Linux/Views.
- // See http://crbug.com/15546.
+ // For now, allow only whitelisted protocols to fire on Linux/Views.
+ // See http://crbug.com/23853 .
return;
}

Powered by Google App Engine
This is Rietveld 408576698