Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2560603002: Explain how to associate RequestFinishedInfo with original request (Closed)

Created:
4 years ago by mgersh
Modified:
4 years ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explain how to associate RequestFinishedInfo with original request This has been generating the most questions since the feature launched. Point it out at the top so it's visible without looking at the specific method which people have had trouble finding. BUG=667312 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Committed: https://crrev.com/74b0f71b1e8238aef97966e59782a365a5205459 Cr-Commit-Position: refs/heads/master@{#436763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M components/cronet/android/api/src/org/chromium/net/RequestFinishedInfo.java View 2 chunks +20 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mgersh
PTAL
4 years ago (2016-12-06 21:30:55 UTC) #3
xunjieli
On 2016/12/06 21:30:55, mgersh wrote: > PTAL lgtm
4 years ago (2016-12-06 21:43:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560603002/1
4 years ago (2016-12-06 21:58:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 22:47:46 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-06 22:51:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74b0f71b1e8238aef97966e59782a365a5205459
Cr-Commit-Position: refs/heads/master@{#436763}

Powered by Google App Engine
This is Rietveld 408576698