Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2560573003: [Offline Pages] Convert Download UI Adapter to using OfflinePageAdded (Closed)

Created:
4 years ago by dewittj
Modified:
4 years ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Convert Download UI Adapter to using OfflinePageAdded Recently OfflinePageModelChanged was renamed to OfflinePageAdded to reflect the reality of when that function was being called. As a result, the OfflinePageAdded function now receives as a parameter the OfflinePageItem that was added. This allows for a much simpler observer function that directly operates on the new page in the download cache. BUG=638276 Committed: https://crrev.com/00c85a032fea6997e8b14e88b288d19618e62b15 Cr-Commit-Position: refs/heads/master@{#437267}

Patch Set 1 #

Patch Set 2 : fix test #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -31 lines) Patch
M components/offline_pages/core/downloads/download_ui_adapter.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/offline_pages/core/downloads/download_ui_adapter.cc View 1 2 2 chunks +10 lines, -23 lines 0 comments Download
M components/offline_pages/core/downloads/download_ui_adapter_unittest.cc View 1 2 1 chunk +1 line, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (18 generated)
dewittj
4 years ago (2016-12-06 23:17:11 UTC) #9
Dmitry Titov
lgtm
4 years ago (2016-12-06 23:42:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560573003/40001
4 years ago (2016-12-08 17:07:54 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-08 17:13:26 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-08 17:14:49 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/00c85a032fea6997e8b14e88b288d19618e62b15
Cr-Commit-Position: refs/heads/master@{#437267}

Powered by Google App Engine
This is Rietveld 408576698