Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2560553004: Revert of [DevTools] Remove methods on Common.Event. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
index 8dda1c03c9e7201a14758582b6270fb29aa43e26..371c4e40a6dac754cbe96bdfe9668e5212b5cd39 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
@@ -599,15 +599,16 @@
}
/**
- * @param {!Common.Event} event
- */
- _longResume(event) {
+ * @return {boolean}
+ */
+ _longResume() {
var debuggerModel = this._prepareToResume();
if (!debuggerModel)
- return;
+ return true;
debuggerModel.skipAllPausesUntilReloadOrTimeout(500);
debuggerModel.resume();
+ return true;
}
/**
@@ -684,7 +685,7 @@
var longResumeButton =
new UI.ToolbarButton(Common.UIString('Resume with all pauses blocked for 500 ms'), 'largeicon-play');
- longResumeButton.addEventListener(UI.ToolbarButton.Events.Click, this._longResume, this);
+ longResumeButton.addEventListener('click', this._longResume.bind(this), this);
debugToolbar.appendToolbarItem(UI.Toolbar.createActionButton(this._togglePauseAction, [longResumeButton], []));
debugToolbar.appendToolbarItem(UI.Toolbar.createActionButton(this._stepOverAction));

Powered by Google App Engine
This is Rietveld 408576698