Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js

Issue 2560553004: Revert of [DevTools] Remove methods on Common.Event. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 350 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 var element = createElementWithClass('div', 'file-system-container'); 361 var element = createElementWithClass('div', 'file-system-container');
362 var header = element.createChild('div', 'file-system-header'); 362 var header = element.createChild('div', 'file-system-header');
363 363
364 header.createChild('div', 'file-system-name').textContent = folderName; 364 header.createChild('div', 'file-system-name').textContent = folderName;
365 var path = header.createChild('div', 'file-system-path'); 365 var path = header.createChild('div', 'file-system-path');
366 path.textContent = fileSystemPath; 366 path.textContent = fileSystemPath;
367 path.title = fileSystemPath; 367 path.title = fileSystemPath;
368 368
369 var toolbar = new UI.Toolbar(''); 369 var toolbar = new UI.Toolbar('');
370 var button = new UI.ToolbarButton(Common.UIString('Remove'), 'largeicon-dele te'); 370 var button = new UI.ToolbarButton(Common.UIString('Remove'), 'largeicon-dele te');
371 button.addEventListener(UI.ToolbarButton.Events.Click, this._removeFileSyste mClicked.bind(this, fileSystem)); 371 button.addEventListener('click', this._removeFileSystemClicked.bind(this, fi leSystem));
372 toolbar.appendToolbarItem(button); 372 toolbar.appendToolbarItem(button);
373 header.appendChild(toolbar.element); 373 header.appendChild(toolbar.element);
374 374
375 return element; 375 return element;
376 } 376 }
377 377
378 /** 378 /**
379 * @param {!Workspace.IsolatedFileSystem} fileSystem 379 * @param {!Workspace.IsolatedFileSystem} fileSystem
380 */ 380 */
381 _removeFileSystemClicked(fileSystem) { 381 _removeFileSystemClicked(fileSystem) {
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
535 return; 535 return;
536 var settings = extension.descriptor()['settings']; 536 var settings = extension.descriptor()['settings'];
537 if (settings && settings.indexOf(setting.name) !== -1) { 537 if (settings && settings.indexOf(setting.name) !== -1) {
538 InspectorFrontendHost.bringToFront(); 538 InspectorFrontendHost.bringToFront();
539 Settings.SettingsScreen._showSettingsScreen(extension.descriptor()['id'] ); 539 Settings.SettingsScreen._showSettingsScreen(extension.descriptor()['id'] );
540 success = true; 540 success = true;
541 } 541 }
542 } 542 }
543 } 543 }
544 }; 544 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698